Skip to content

Async write headers#2762

Merged
asvetlov merged 4 commits intomasterfrom
async-write-headers
Feb 26, 2018
Merged

Async write headers#2762
asvetlov merged 4 commits intomasterfrom
async-write-headers

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Feb 26, 2018

Make writer.write_headers() a coroutine

@kxepal
Copy link
Copy Markdown
Member

kxepal commented Feb 26, 2018

LGFM, but could you remind me, please, why all this need? What's the goal?

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Feb 26, 2018

I guess it's related to #2743 (comment), right?

@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Feb 26, 2018

No, it is for #2698

@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Feb 26, 2018

After switching all writes to coroutines we can drop write buffers.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #2762 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   97.97%   97.98%   +0.01%     
==========================================
  Files          39       39              
  Lines        7340     7339       -1     
  Branches     1285     1284       -1     
==========================================
  Hits         7191     7191              
  Misses         47       47              
+ Partials      102      101       -1
Impacted Files Coverage Δ
aiohttp/web_response.py 98.18% <100%> (ø) ⬆️
aiohttp/client_reqrep.py 97.39% <100%> (ø) ⬆️
aiohttp/test_utils.py 98.85% <100%> (+0.37%) ⬆️
aiohttp/http_writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38e14c...37ee8de. Read the comment docs.

@kxepal
Copy link
Copy Markdown
Member

kxepal commented Feb 26, 2018

Cool! Thanks.

@asvetlov asvetlov merged commit 0a94431 into master Feb 26, 2018
@asvetlov asvetlov deleted the async-write-headers branch February 26, 2018 10:34
This was referenced Mar 22, 2018
Closed
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kxepal kxepal kxepal approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asvetlov @kxepal @webknjaz @codecov-io