Skip to content

Fix MultipartWriter.append* no longer returning part/payload.#2759

Merged
asvetlov merged 2 commits intoaio-libs:3.0from
terencehonles:fix-multipartwriter-append-return-value
Feb 26, 2018
Merged

Fix MultipartWriter.append* no longer returning part/payload.#2759
asvetlov merged 2 commits intoaio-libs:3.0from
terencehonles:fix-multipartwriter-append-return-value

Conversation

@terencehonles
Copy link
Copy Markdown
Contributor

@terencehonles terencehonles commented Feb 26, 2018 •
edited by asvetlov
Loading

What do these changes do?

  • Fixes commit: caa6bdb

    MultipartWriter.append methods used to return the part appended to the writer so one could set the content_disposition, etc. This patch restores that functionality so the code matches the documentation in multipart.rst

  • This patch also makes append_json use the JsonPayload object instead of duplicating functionality.

Are there changes in behavior for the user?

Fix regression

Related issue number

#1798

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@terencehonles
fix MultipartWriter.append* no longer returning part/payload
8b10932 
- Fixes commit: caa6bdb

  MultipartWriter.append methods used to return the part appended to the
  writer so one could set the content_disposition, etc. This patch
  restores that functionality so the code matches the documentation in
  multipart.rst

- This patch also makes append_json use the JsonPayload object instead
  of duplicating functionality.
@terencehonles
add change entry
cad70ba
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #2759 into 3.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              3.0    #2759   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          39       39           
  Lines        7340     7340           
  Branches     1285     1285           
=======================================
  Hits         7191     7191           
  Misses         47       47           
  Partials      102      102
Impacted Files Coverage Δ
aiohttp/multipart.py 95.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36179d1...cad70ba. Read the comment docs.

kxepal
kxepal approved these changes Feb 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. It's interesting that append_form already tried to return result of append_payload, but those returned nothing.

@asvetlov asvetlov merged commit 6c92e8f into aio-libs:3.0 Feb 26, 2018
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Feb 26, 2018

Thanks!

@asvetlov asvetlov mentioned this pull request Feb 26, 2018
Closed
@terencehonles terencehonles deleted the fix-multipartwriter-append-return-value branch February 26, 2018 08:20
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 22, 2018
Closed
@roganov roganov mentioned this pull request Apr 19, 2018
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@kxepal kxepal kxepal approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terencehonles @codecov-io @asvetlov @kxepal