Skip to content

Rename PayloadWriter to StreamWriter#2654

Merged
asvetlov merged 3 commits intomasterfrom
rename_payloadwriter_streamwriter
Jan 12, 2018
Merged

Rename PayloadWriter to StreamWriter#2654
asvetlov merged 3 commits intomasterfrom
rename_payloadwriter_streamwriter

Conversation

@pfreixes
Copy link
Copy Markdown
Contributor

@pfreixes pfreixes commented Jan 11, 2018

What do these changes do?

Rename the PayloadWriter class to StreamWriter, having consistency with the reader side which has a class called StreamReader.

Are there changes in behavior for the user?

No

Related issue number

#2109

Checklist

  • I think the code is well written
  • Unit tests for the changes exist

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2018 •
edited
Loading

Codecov Report

Merging #2654 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2654   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          39       39           
  Lines        7245     7245           
  Branches     1257     1257           
=======================================
  Hits         7099     7099           
  Misses         45       45           
  Partials      101      101
Impacted Files Coverage Δ
aiohttp/http.py 100% <ø> (ø) ⬆️
aiohttp/payload.py 98.74% <ø> (ø) ⬆️
aiohttp/http_writer.py 100% <100%> (ø) ⬆️
aiohttp/web_protocol.py 91.57% <100%> (ø) ⬆️
aiohttp/client_reqrep.py 97.36% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 97.87% <100%> (ø) ⬆️
aiohttp/abc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c719e3e...108b8ad. Read the comment docs.

@asvetlov asvetlov merged commit b348e0f into master Jan 12, 2018
@asvetlov asvetlov deleted the rename_payloadwriter_streamwriter branch January 12, 2018 20:20
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Jan 12, 2018

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pfreixes @codecov-io @asvetlov