allow custom port to TestServer#2613
allow custom port to TestServer#2613samuelcolvin merged 5 commits intoaio-libs:masterfrom samuelcolvin:testservr-custom-port
Conversation
|
The PR assumes different approach for test writing than used by me usually (I prefer to find first unused port) but might be useful for some scenarios. Ok with changes but please update documentation. |
asvetlov
left a comment
There was a problem hiding this comment.
LGTM!
Please merge when green
|
Ooops. |
|
docs added.
Same, but sometimes I want to decide the port in a session scoped fixture then use it in a test scoped fixture later. |
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
=========================================
+ Coverage 97.9% 97.9% +<.01%
=========================================
Files 38 38
Lines 7314 7317 +3
Branches 1270 1271 +1
=========================================
+ Hits 7161 7164 +3
Misses 49 49
Partials 104 104
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Allow the port to be set when creating test servers (and therefore test clients).
This is useful when you want you want the port of a test server to fixed for a sesssion but the test server to be ephemeral and be (re)created for all tests.
Are there changes in behavior for the user?
Not unless they want to set the port
Checklist
CHANGESfolder