Skip to content

Correct request.app context (for handlers not just middlewares)#2577

Merged
asvetlov merged 3 commits intomasterfrom
nested_apps_with_middleware
Dec 4, 2017
Merged

Correct request.app context (for handlers not just middlewares)#2577
asvetlov merged 3 commits intomasterfrom
nested_apps_with_middleware

Conversation

@popravich
Copy link
Copy Markdown
Member

@popravich popravich commented Nov 30, 2017

This is an update to #2550
_fix_request_current_app middleware was added if application had any middlewares.
Now it is yielded unconditionally to set proper context for handlers as well.

@popravich popravich requested a review from asvetlov November 30, 2017 10:31
@popravich
Copy link
Copy Markdown
Member Author

popravich commented Nov 30, 2017

@asvetlov , I'm not sure about target branch — should it be master or some bugfix branch?

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Dec 4, 2017

I'll cherry-pick to 2.3 myself

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2017 •
edited
Loading

Codecov Report

Merging #2577 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files          36       36              
  Lines        7229     7228       -1     
  Branches     1262     1261       -1     
==========================================
- Hits         7064     7063       -1     
  Misses         58       58              
  Partials      107      107
Impacted Files Coverage Δ
aiohttp/web.py 97.86% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bb501...3dac5b6. Read the comment docs.

@asvetlov asvetlov merged commit a910801 into master Dec 4, 2017
@asvetlov asvetlov deleted the nested_apps_with_middleware branch December 4, 2017 16:32
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Dec 4, 2017

thanks!

asvetlov pushed a commit that referenced this pull request Dec 4, 2017
@popravich @asvetlov
Correct request.app context (for handlers not just middlewares) (#2577)
e47df9a 
* yield _fix_request_current_app middleware uncoditionally; update test; (see #2550)

* Add change notes
@pfreixes
Copy link
Copy Markdown
Contributor

pfreixes commented Dec 26, 2017

Just FYI this fix impacted with a loss btw 5%-10% of the performance, we should try to make it in some way that does not reuse the middlewares code to setup also the current app when there are no middlewares installed.

@amirouche
Copy link
Copy Markdown

amirouche commented Dec 27, 2017

Does it make sens to optimize for the case where there is no middleware?

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Dec 27, 2017

The check should analyze not only middlewares but nested applications also.
Pull Request is welcome!

@popravich
Copy link
Copy Markdown
Member Author

popravich commented Dec 27, 2017

The performance loss might be introduced by making Request.app a real property and not cached one.
So I guess optimizing for the case when there are no middlewares might not bring those percents back.

pfreixes pushed a commit that referenced this pull request Dec 28, 2017
Skip middleware code when there are no user middlewares installed
bb4a60c 
Fixes performance issue introduced by #2577, boosting from 8K req/sec
to almost 9K req/sec.

If there are no middlewares installed by the user the attribute
`request._match_info.current_app` already looks at to the right app,
this is by design.
@pfreixes pfreixes mentioned this pull request Dec 28, 2017
Merged
pfreixes added a commit that referenced this pull request Dec 28, 2017
@pfreixes
Skip middleware code when there are no user middlewares installed (#2629
af3cb34 
)

* Skip middleware code when there are no user middlewares installed

Fixes performance issue introduced by #2577, boosting from 8K req/sec
to almost 9K req/sec.

If there are no middlewares installed by the user the attribute
`request._match_info.current_app` already looks at to the right app,
this is by design.
This was referenced Mar 15, 2018
Closed
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR bug outdated server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@popravich @asvetlov @codecov-io @pfreixes @amirouche