Skip to content

Properly close sessions in _SessionRequestContextManager#2441

Merged
asvetlov merged 2 commits intoaio-libs:2.3from
hynek:2.3
Oct 30, 2017
Merged

Properly close sessions in _SessionRequestContextManager#2441
asvetlov merged 2 commits intoaio-libs:2.3from
hynek:2.3

Conversation

@hynek
Copy link
Copy Markdown
Contributor

@hynek hynek commented Oct 30, 2017 •
edited
Loading

What do these changes do?

Fix a bunch of DeprecationWarning: ClientSession.close() is a coroutine self._session.close().

Also changed bare except to BaseException which is equivalent but won’t raise a warning on current flake8s. I’m aware current master catches Exception, but that seems like backward-combat violation in a point release.

Are there changes in behavior for the user?

Less warnings. I have a bit of a hard time writing tests because the test suite doesn’t work on my machine…

Related issue number

Didn’t find any.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 30, 2017 •
edited
Loading

Codecov Report

Merging #2441 into 2.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2441   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          39       39           
  Lines        8224     8224           
  Branches     1442     1442           
=======================================
  Hits         7997     7997           
  Misses         98       98           
  Partials      129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc392f...eb3ba3f. Read the comment docs.

@asvetlov asvetlov merged commit 10e0d97 into aio-libs:2.3 Oct 30, 2017
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Oct 30, 2017

Thanks!
Will publish a new bugfix release soon.
@hellysmile wants to add a couple fixes too.

@hellysmile hellysmile mentioned this pull request Oct 30, 2017
Closed
@hynek hynek deleted the 2.3 branch October 30, 2017 12:06
@arthurdarcet arthurdarcet mentioned this pull request Nov 8, 2017
Closed
5 tasks
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hynek @codecov-io @asvetlov