Fix incorrect warning in StreamReader.#2251
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Sep 8, 2017
Merged
Conversation
roganov
force-pushed
the
fix-warning-in-streamreader
branch
from
5fce093 to
fe8767f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
=========================================
+ Coverage 97.2% 97.2% +<.01%
=========================================
Files 39 39
Lines 7945 7946 +1
Branches 1378 1378
=========================================
+ Hits 7723 7724 +1
Misses 98 98
Partials 124 124
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Sep 8, 2017
Member
|
Thanks! |
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I was getting a random warning when using
request.multipart()concerning EOF state ofStreamReader, though I was making exactly oneread()for everyBodyPartReader. The issue was thatunread_datawasn't resetting_eof_counter.Are there changes in behavior for the user?
No
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.