Raise RuntimeError is you try to set the Content Length with chunked encoding enable#1941
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Jun 8, 2017
Conversation
julien-duponchelle
force-pushed
the
runtime_error_content_length
branch
from
d03f9a7 to
07771f7
Compare
Member
|
could you add similar check for chunked encoding? |
…unked encoding at the same time
julien-duponchelle
force-pushed
the
runtime_error_content_length
branch
from
07771f7 to
a064de8
Compare
Contributor
Author
|
Commit updated in order to add a similar check for enable_chunked_encoding |
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
+ Coverage 97.08% 97.08% +<.01%
==========================================
Files 37 37
Lines 7609 7613 +4
Branches 1327 1329 +2
==========================================
+ Hits 7387 7391 +4
Misses 100 100
Partials 122 122
Continue to review full report at Codecov.
|
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
If you try to set a content length on a response with chunked encoding enable you get a RuntimeError
Are there changes in behavior for the user?
User will get an exception and not will be able to set the content length.
Related issue number
It's after a discussion here: #1933
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.