Skip to content

Start test server on socket instead of host/port pair.#1896

Merged
fafhrd91 merged 1 commit intoaio-libs:masterfrom
playpauseandstop:master
May 17, 2017
Merged

Start test server on socket instead of host/port pair.#1896
fafhrd91 merged 1 commit intoaio-libs:masterfrom
playpauseandstop:master

Conversation

@playpauseandstop
Copy link
Copy Markdown
Contributor

@playpauseandstop playpauseandstop commented May 16, 2017

What do these changes do?

Fix random OSError on running tests for aiohttp app on large amount of tests.

Are there changes in behavior for the user?

Changes should just work for most of users. It's improvement of creating test server, by passing sock instead of host / port pair

Related issue number

#1895

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented May 16, 2017

The perfect catch, very thank you @playpauseandstop
Will merge it after CI passed

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented May 16, 2017

But please add an entry to CHANGES.txt like Make test server more reliable. #1896

@asvetlov asvetlov self-requested a review May 16, 2017 16:17
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 16, 2017 •
edited
Loading

Codecov Report

Merging #1896 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
+ Coverage   97.06%   97.06%   +<.01%     
==========================================
  Files          37       37              
  Lines        7558     7560       +2     
  Branches     1314     1314              
==========================================
+ Hits         7336     7338       +2     
  Misses        100      100              
  Partials      122      122
Impacted Files Coverage Δ
aiohttp/test_utils.py 99.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59679c7...f2380b8. Read the comment docs.

@playpauseandstop
Copy link
Copy Markdown
Contributor Author

playpauseandstop commented May 17, 2017

@asvetlov

Updated CHANGES.txt & CONTRIBUTORS.txt

@fafhrd91 fafhrd91 merged commit 57b811b into aio-libs:master May 17, 2017
@fafhrd91
Copy link
Copy Markdown
Member

fafhrd91 commented May 17, 2017

thanks!

@asvetlov asvetlov mentioned this pull request May 20, 2017
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@playpauseandstop @asvetlov @codecov-io @fafhrd91