Merged
Conversation
emlove
force-pushed
the
python-34-noop-fix
branch
from
537d349 to
2ce816b
Compare
Member
|
could you rebase against master and fix spelling |
Contributor
Author
|
Sure. Can you point out the spelling problem, though? |
Member
|
you can do "make doc-spelling" |
emlove
force-pushed
the
python-34-noop-fix
branch
from
2ce816b to
6407eff
Compare
emlove
force-pushed
the
python-34-noop-fix
branch
from
6407eff to
2570f78
Compare
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 37 37
Lines 7509 7509
Branches 1306 1306
=======================================
Hits 7298 7298
Misses 89 89
Partials 122 122
Continue to review full report at Codecov.
|
Contributor
Author
|
Done. Thanks for pointing me in the right direction. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change switches the
noophelper in python 3.4 from returning a tuple to returning an empty coroutine. Python 3.4 supports the coroutine decorator syntax, so I'm not sure why this was done differently to begin with. The current code is causing assertion errors when the coroutine is passed to loop.create_task.After this change both branches were the same, so the branching is removed.
Are there changes in behavior for the user?
No
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.