Clearer error message for URL without a hostname.#1691
Closed
bitdancer wants to merge 1 commit intoaio-libs:1.3from
Closed
Clearer error message for URL without a hostname.#1691bitdancer wants to merge 1 commit intoaio-libs:1.3from
bitdancer wants to merge 1 commit intoaio-libs:1.3from
Conversation
When I got the existing error message I had no idea what it meant. A little digging in the code reveals that the problem was I provided a URL that did not contain a hostname, so aiohttp was unable to parse the hostname out of that URL. Here is an alternate wording for the error message that I hope will lead the library user to understand what went wrong more quickly.
Member
|
could you create PR against https://github.com/aio-libs/aiohttp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I got the existing error message I had no idea what it meant. A little digging in the code reveals that the problem was I provided a URL that did not contain a hostname, so aiohttp was unable to parse the hostname out of that URL. Here is an alternate wording for the error message that I hope will lead the library user to understand what went wrong more quickly.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.