Having a : or @ in a route does not work#1552
Merged
fafhrd91 merged 1 commit intoaio-libs:masterfrom Feb 6, 2017
Merged
Conversation
436f279 to
0732059
Compare
…he one done in yarl.URL.__init__
0732059 to
d7f724b
Compare
Codecov Report@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 98.59% 98.94% +0.34%
==========================================
Files 30 30
Lines 7055 6996 -59
Branches 1176 1169 -7
==========================================
- Hits 6956 6922 -34
+ Misses 58 37 -21
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL escaping done for the request urls and in the router when adding resources should be consistent.
Currently,
:and@are considered "safe" by yarl and not escaped inrequest.rel_url.raw_path; but the router does escape them and so the created resource never match:Output:
I have updated the router to avoid using
yarl.quoteand useyarl.URL(…).raw_pathinstead, ensuring the escaping is consistent in both cases. (and I added a test that fails without this patch)