allow starting variables with an underscore#1379
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Nov 7, 2016
Merged
Conversation
Mongo ids are useful as a named resource in a route, but they are usually named `_id` and are excluded by the current regex
Current coverage is 98.78% (diff: 100%)@@ master #1379 diff @@
==========================================
Files 29 29
Lines 6762 6762
Methods 0 0
Messages 0 0
Branches 1123 1123
==========================================
Hits 6680 6680
Misses 38 38
Partials 44 44
|
Member
|
The change is good to me. |
Member
|
Thanks |
asvetlov
pushed a commit
that referenced
this pull request
Nov 7, 2016
Mongo ids are useful as a named resource in a route, but they are usually named `_id` and are excluded by the current regex
Contributor
Author
|
Thanks, and good to know for the non-ascii names. I'll have a go a that too if I ever need it For reference, if anyone stumble here, python identifiers are: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the named resources identifiers to start with an underscore
Mongo ids are useful as a named resource in a route, but they are usually named
_idand are excluded by the current regexIf this isn't an acceptable change, then the documentation should imo be updated to specify what is an acceptable route identifier (
[a-zA-Z][_a-zA-Z0-9]*currently)