Fixed StreamReader._read_nowait#1297
Merged
asvetlov merged 2 commits intoaio-libs:1.0from Oct 11, 2016
Merged
Conversation
Current coverage is 98.53% (diff: 100%)@@ 1.0 #1297 diff @@
==========================================
Files 29 29
Lines 6545 6553 +8
Methods 0 0
Messages 0 0
Branches 1095 1097 +2
==========================================
+ Hits 6449 6457 +8
Misses 45 45
Partials 51 51
|
Contributor
Author
|
@jettify I guess I found a way to speed up thing further in our particular use case. In the example above there is this line |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
StreamReader._read_nowaitwas returning a single chunk fromself._buffereven if a much larger chunk was requested and available. This behavior caused performance regressions.Simple test:
Before:
After:
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES.rst#isuue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.