CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing rodrigobnogueira:fix/test-invalid-idna-3.11 (07921b1) with master (4bb9e6e)}

Summary

✅ 59 untouched benchmarks

CI is failing due to flaky test (see #11992)

=========================== short test summary info ============================
XFAIL tests/test_http_parser.py::test_http_response_parser_strict_headers[py-parser-pyloop] - Py parser is lenient. May update py-parser later.
FAILED tests/test_imports.py::test_import_time - assert 206 < 200
=========== 1 failed, 7 passed, 4368 deselected, 1 xfailed in 10.41s ===========

CI is failing due to flaky test (see #11992)

Well, actually idna is probably the cause that started this test failing...
kjd/idna#188

It seems that's it's unreliable enough that a more recent version managed to pass and get merged regardless, hence the flakiness we see today. Ideally we can pull the import time back down in future...

CI is failing due to flaky test (see #11992)

Well, actually idna is probably the cause that started this test failing... kjd/idna#188

It seems that's it's unreliable enough that a more recent version managed to pass and get merged regardless, hence the flakiness we see today. Ideally we can pull the import time back down in future...

Ah, that’s revealing.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (4bb9e6e) to head (07921b1).
⚠️ Report is 8 commits behind head on master.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##           master   #12036      +/-   ##
==========================================
- Coverage   98.76%   98.75%   -0.01%     
==========================================
  Files         127      127              
  Lines       44658    44658              
  Branches     2372     2372              
==========================================
- Hits        44105    44104       -1     
  Misses        393      393              
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9053e8c on top of patchback/backports/3.13/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036

Backporting merged PR #12036 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.13/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036 upstream/3.13

4. Now, cherry-pick PR Fix test_invalid_idna for idna 3.11 compatibility #12036 contents into that branch:

   $ git cherry-pick -x 9053e8ce4a72cfc38eba9f224d4d432371c0c25b

   If it'll yell at you with something like fatal: Commit 9053e8ce4a72cfc38eba9f224d4d432371c0c25b is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 9053e8ce4a72cfc38eba9f224d4d432371c0c25b

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Fix test_invalid_idna for idna 3.11 compatibility #12036 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.13/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9053e8c on top of patchback/backports/3.14/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036

Backporting merged PR #12036 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.14/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036 upstream/3.14

4. Now, cherry-pick PR Fix test_invalid_idna for idna 3.11 compatibility #12036 contents into that branch:

   $ git cherry-pick -x 9053e8ce4a72cfc38eba9f224d4d432371c0c25b

   If it'll yell at you with something like fatal: Commit 9053e8ce4a72cfc38eba9f224d4d432371c0c25b is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 9053e8ce4a72cfc38eba9f224d4d432371c0c25b

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Fix test_invalid_idna for idna 3.11 compatibility #12036 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.14/9053e8ce4a72cfc38eba9f224d4d432371c0c25b/pr-12036

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@rodrigobnogueira have you looked into backporting?

sorry, I'll do it today

done