Skip to content

Fix loading netrc when NETRC env var is not set#11714

Merged
bdraco merged 9 commits intomasterfrom
netrc_without_env_fix
Oct 28, 2025
Merged

Fix loading netrc when NETRC env var is not set#11714
bdraco merged 9 commits intomasterfrom
netrc_without_env_fix

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 24, 2025

What do these changes do?

I optimized this one a bit too much assuming NETRC would always be set in #11634

fixes #11713

Are there changes in behavior for the user?

fix regression

Is it a substantial burden for the maintainers to support this?

no

@bdraco
Fix loading netrc when NETRC env var is not set
1e3fb9e 
I optimized this one a bit too much assuming NETRC would always be set in
#11634

fixes #11713
@bdraco bdraco added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Oct 24, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2025
@bdraco bdraco mentioned this pull request Oct 24, 2025
Closed
1 task
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (1569ad9) to head (654d7e6).
⚠️ Report is 227 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11714   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         127      127           
  Lines       43549    43573   +24     
  Branches     2327     2327           
=======================================
+ Hits        43003    43027   +24     
  Misses        390      390           
  Partials      156      156
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.69% <100.00%> (-0.01%) ⬇️
OS-macOS 97.58% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.15% <100.00%> (-0.01%) ⬇️
Py-3.10.18 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.85% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.95% <100.00%> (-0.01%) ⬇️
Py-3.13.7 97.95% <100.00%> (+<0.01%) ⬆️
Py-3.13.8 97.44% <100.00%> (+0.01%) ⬆️
Py-3.14.0 98.15% <100.00%> (-0.01%) ⬇️
Py-3.14.0t 97.23% <100.00%> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 90.54% <100.00%> (-2.96%) ⬇️
VM-macos 97.58% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11714 will not alter performance

Comparing netrc_without_env_fix (654d7e6) with master (1569ad9)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on master (6a2809d) during the generation of this report, so 1569ad9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@bdraco bdraco marked this pull request as ready for review October 24, 2025 14:17
webknjaz
webknjaz reviewed Oct 24, 2025
View reviewed changes
bdraco and others added 5 commits October 24, 2025 09:35
@bdraco @webknjaz
Update CHANGES/11713.bugfix.rst
58dbe03 
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@bdraco @webknjaz
Update tests/conftest.py
102c7cf 
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d004843 
for more information, see https://pre-commit.ci
@bdraco
windows tweas
2154287
@bdraco
Merge remote-tracking branch 'upstream/netrc_without_env_fix' into ne…
654d7e6 
…trc_without_env_fix
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Oct 28, 2025

Thanks

@bdraco bdraco merged commit 0d77d0d into master Oct 28, 2025
41 checks passed
@bdraco bdraco deleted the netrc_without_env_fix branch October 28, 2025 15:34
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Oct 28, 2025 •
edited
Loading

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/0d77d0d64461bd9c98b30fb1f5ab246bb58f2b4e/pr-11714

Backported as #11727

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 28, 2025
@bdraco @webknjaz
@pre-commit-ci @patchback
Fix loading netrc when NETRC env var is not set (#11714)
5f7f41b 
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0d77d0d)
@patchback patchback bot mentioned this pull request Oct 28, 2025
Merged
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Oct 28, 2025 •
edited
Loading

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/0d77d0d64461bd9c98b30fb1f5ab246bb58f2b4e/pr-11714

Backported as #11728

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 28, 2025
@bdraco @webknjaz
@pre-commit-ci @patchback
Fix loading netrc when NETRC env var is not set (#11714)
07a3476 
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0d77d0d)
@patchback patchback bot mentioned this pull request Oct 28, 2025
Merged
bdraco added a commit that referenced this pull request Oct 28, 2025
@patchback @bdraco
@webknjaz @pre-commit-ci
[PR #11714/0d77d0d6 backport][3.14] Fix loading netrc when NETRC env …
57ad7fa 
…var is not set (#11728)

Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fixes #11713
bdraco added a commit that referenced this pull request Oct 28, 2025
@patchback @bdraco
@webknjaz @pre-commit-ci
[PR #11714/0d77d0d6 backport][3.13] Fix loading netrc when NETRC env …
b734e04 
…var is not set (#11727)

Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fixes #11713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The default .netrc file in the home directory is no longer used

2 participants

@bdraco @webknjaz