Skip to content

Make prettier urls if query is empty dict#1143

Merged
asvetlov merged 1 commit intoaio-libs:masterfrom
xen:master
Sep 7, 2016
Merged

Make prettier urls if query is empty dict#1143
asvetlov merged 1 commit intoaio-libs:masterfrom
xen:master

Conversation

@xen
Copy link
Copy Markdown
Contributor

@xen xen commented Sep 6, 2016

What do these changes do?

Make better urls for named routes when query is empty dict.

Are there changes in behavior for the user?

Should not require to update or change existed code.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 6, 2016

Current coverage is 98.28% (diff: 100%)

Merging #1143 into master will not change coverage

@@             master      #1143   diff @@
==========================================
  Files            28         28          
  Lines          6489       6489          
  Methods           0          0          
  Messages          0          0          
  Branches       1087       1087          
==========================================
  Hits           6378       6378          
  Misses           61         61          
  Partials         50         50          

Powered by Codecov. Last update 5617801...5888a86

@asvetlov asvetlov merged commit ebce967 into aio-libs:master Sep 7, 2016
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Sep 7, 2016

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants