Skip to content

[PR #10910/36a2567 backport][3.11] Remove mocked coro from tests#10912

Merged
bdraco merged 1 commit into3.11from
patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910
May 20, 2025
Merged

[PR #10910/36a2567 backport][3.11] Remove mocked coro from tests#10912
bdraco merged 1 commit into3.11from
patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 20, 2025

This is a partial backport of 36a2567, make_mocked_coro is still left in the test utils for backwards compat, and only the internal tests are updated.

(cherry picked from commit 36a2567)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2025
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label May 20, 2025
Comment thread tests/test_client_request.py Outdated
Comment thread tests/test_client_request.py Outdated
@bdraco bdraco force-pushed the patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 branch from 4a3a6d3 to 5fddbda Compare May 20, 2025 21:37
@bdraco bdraco changed the title Remove mocked coro (#10910) [PR #10910/36a2567 backport][3.11] Remove mocked coro May 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.08%. Comparing base (bd77b3e) to head (12c2d8d).
⚠️ Report is 13 commits behind head on 3.11.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10912      +/-   ##
==========================================
+ Coverage   98.06%   98.08%   +0.01%     
==========================================
  Files         126      126              
  Lines       37745    37728      -17     
  Branches     4562     4566       +4     
==========================================
- Hits        37016    37006      -10     
+ Misses        548      544       -4     
+ Partials      181      178       -3     
Flag Coverage Δ
CI-GHA 97.97% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.67% <97.36%> (+<0.01%) ⬆️
OS-Windows 94.68% <63.81%> (+0.32%) ⬆️
OS-macOS 96.80% <97.36%> (+0.08%) ⬆️
Py-3.10.11 96.67% <100.00%> (-0.03%) ⬇️
Py-3.10.17 97.18% <97.36%> (?)
Py-3.11.12 97.25% <97.36%> (+0.65%) ⬆️
Py-3.11.9 96.75% <100.00%> (?)
Py-3.12.10 97.75% <100.00%> (+0.26%) ⬆️
Py-3.13.3 97.68% <100.00%> (?)
Py-3.9.13 96.58% <100.00%> (+2.42%) ⬆️
Py-3.9.22 97.09% <97.36%> (-0.06%) ⬇️
Py-pypy7.3.16 96.66% <97.36%> (?)
VM-macos 96.80% <97.36%> (+0.08%) ⬆️
VM-ubuntu 97.67% <97.36%> (+<0.01%) ⬆️
VM-windows 94.68% <63.81%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10912 will not alter performance

Comparing patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 (12c2d8d) with 3.11 (bd77b3e)

Summary

✅ 56 untouched benchmarks

@bdraco bdraco closed this May 20, 2025
@bdraco bdraco reopened this May 20, 2025
@bdraco bdraco force-pushed the patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 branch from 5fddbda to 12c2d8d Compare May 20, 2025 21:57
@bdraco bdraco changed the title [PR #10910/36a2567 backport][3.11] Remove mocked coro [PR #10910/36a2567 backport][3.11] Remove mocked coro from tests May 20, 2025
@bdraco bdraco marked this pull request as ready for review May 20, 2025 22:07
@bdraco bdraco requested review from asvetlov and webknjaz as code owners May 20, 2025 22:07
@bdraco bdraco enabled auto-merge (squash) May 20, 2025 22:07
@bdraco bdraco merged commit 24b0fdd into 3.11 May 20, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 branch May 20, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant