Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.76%. Comparing base (802152a) to head (dfbcb9f).
⚠️ Report is 508 commits behind head on master.
✅ All tests successful. No failed tests found.

@@           Coverage Diff            @@
##           master   #10897    +/-   ##
========================================
  Coverage   98.75%   98.76%            
========================================
  Files         129      129            
  Lines       38931    39085   +154     
  Branches     2164     2169     +5     
========================================
+ Hits        38447    38601   +154     
  Misses        336      336            
  Partials      148      148            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CodSpeed Performance Report

Merging #10897 will improve performances by 8.06%

_{Comparing single_async_resolver (dfbcb9f) with master (a4be2cb)}

Summary

⚡ 1 improvements
✅ 59 untouched benchmarks

Benchmarks breakdown

oh right, we support multiple event loops still so we need to account for that

Something else is actually leaking them outside of this

I need to move the fixture to top level and make it auto use to find it.

I'm going to put it at top level, and than revert it after I fix all the test leaks

We have far too many session leaks to fix them in this PR. I'll have to count before and after instead

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4624fed on top of patchback/backports/3.12/4624fed82608d9b659c4284814a570e0b332b8db/pr-10897

Backporting merged PR #10897 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.12/4624fed82608d9b659c4284814a570e0b332b8db/pr-10897 upstream/3.12

4. Now, cherry-pick PR Fix DNS resolver object churn for multiple sessions #10897 contents into that branch:

   $ git cherry-pick -x 4624fed82608d9b659c4284814a570e0b332b8db

   If it'll yell at you with something like fatal: Commit 4624fed82608d9b659c4284814a570e0b332b8db is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 4624fed82608d9b659c4284814a570e0b332b8db

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Fix DNS resolver object churn for multiple sessions #10897 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.12/4624fed82608d9b659c4284814a570e0b332b8db/pr-10897

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.