make_mocked_request now accepts dict as headers#1073
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Aug 15, 2016
argaen:issue-1068/make_mocked_request_accept_dict
Merged
make_mocked_request now accepts dict as headers#1073asvetlov merged 2 commits intoaio-libs:masterfrom argaen:issue-1068/make_mocked_request_accept_dict
asvetlov merged 2 commits intoaio-libs:masterfrom
argaen:issue-1068/make_mocked_request_accept_dict
Conversation
Current coverage is 97.64% (diff: 100%)@@ master #1073 diff @@
==========================================
Files 28 28
Lines 6532 6399 -133
Methods 0 0
Messages 0 0
Branches 1101 1085 -16
==========================================
- Hits 6368 6248 -120
+ Misses 88 79 -9
+ Partials 76 72 -4
|
aiohttp/test_utils.py
Outdated
| :param headers: CIMultiDict with all request headers | ||
| :type headers: multidict.CIMultiDict | ||
| :param headers: dict with all request headers | ||
| :type headers: dict |
Member
There was a problem hiding this comment.
it can be multidict also. Technically the parameter is something acceptable by CIMultiDict ctor. Say, a list of pairs is also working.
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
make_mocked_request accepts dict instance as headers arg
Related issue number
#1068
Checklist