Skip to content

Fix test_client fixture to allow multiple clients per test#1072

Merged
popravich merged 1 commit intomasterfrom
pytest_plugin
Aug 13, 2016
Merged

Fix test_client fixture to allow multiple clients per test#1072
popravich merged 1 commit intomasterfrom
pytest_plugin

Conversation

@popravich
Copy link
Copy Markdown
Member

@popravich popravich commented Aug 12, 2016

What do these changes do?

test_client fixture now allows multiple client instances:

from project import frontend, api

async def test_full_app(test_client):
    front_client = await test_client(frontend.make_app)
    api_client = await test_client(api.make_app)
    # test complete application

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 12, 2016 •
edited
Loading

Current coverage is 97.48% (diff: 100%)

Merging #1072 into master will increase coverage by <.01%

@@             master      #1072   diff @@
==========================================
  Files            28         28          
  Lines          6532       6533     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       1101       1101          
==========================================
+ Hits           6368       6369     +1   
  Misses           88         88          
  Partials         76         76

Powered by Codecov. Last update b0231dc...8e5d508

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Aug 12, 2016

Not bad but what's you use case?
I'm just curious.

@popravich
Copy link
Copy Markdown
Member Author

popravich commented Aug 12, 2016

Use case is almost as in example above:
project has two servers - public and internal APIs.
I'm testing that touching private API properly propagates data to public API.

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Aug 12, 2016

lgtm

@popravich popravich merged commit 8131cae into master Aug 13, 2016
@popravich popravich deleted the pytest_plugin branch August 13, 2016 12:30
@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@popravich @codecov-io @asvetlov