Skip to content

Docs fixups following implement socket factory (#10534)#10568

Merged
bdraco merged 1 commit intoaio-libs:masterfrom
TimMenninger:tcp-socket-factory-style-fixups
Mar 30, 2025
Merged

Docs fixups following implement socket factory (#10534)#10568
bdraco merged 1 commit intoaio-libs:masterfrom
TimMenninger:tcp-socket-factory-style-fixups

Conversation

@TimMenninger
Copy link
Copy Markdown
Contributor

What do these changes do?

Docs

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@TimMenninger TimMenninger mentioned this pull request Mar 16, 2025
5 tasks
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #10568 will not alter performance

Comparing TimMenninger:tcp-socket-factory-style-fixups (f378fbb) with master (b6f34d4)

Summary

✅ 47 untouched benchmarks

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (b6f34d4) to head (f378fbb).
Report is 527 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10568   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         125      125           
  Lines       37368    37368           
  Branches     2064     2064           
=======================================
  Hits        36886    36886           
  Misses        335      335           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.58% <ø> (ø)
OS-Linux 98.25% <ø> (ø)
OS-Windows 96.18% <ø> (-0.01%) ⬇️
OS-macOS 97.36% <ø> (-0.01%) ⬇️
Py-3.10.11 97.27% <ø> (-0.01%) ⬇️
Py-3.10.16 97.81% <ø> (-0.01%) ⬇️
Py-3.11.11 97.85% <ø> (-0.05%) ⬇️
Py-3.11.9 97.35% <ø> (-0.01%) ⬇️
Py-3.12.9 98.35% <ø> (ø)
Py-3.13.2 98.34% <ø> (-0.01%) ⬇️
Py-3.9.13 97.15% <ø> (-0.02%) ⬇️
Py-3.9.21 97.68% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 92.04% <ø> (-4.55%) ⬇️
VM-macos 97.36% <ø> (-0.01%) ⬇️
VM-ubuntu 98.25% <ø> (ø)
VM-windows 96.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimMenninger TimMenninger force-pushed the tcp-socket-factory-style-fixups branch from c41d7a4 to b2cd192 Compare March 19, 2025 13:53
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 19, 2025
@TimMenninger TimMenninger force-pushed the tcp-socket-factory-style-fixups branch from b2cd192 to 000d120 Compare March 19, 2025 14:05
@TimMenninger TimMenninger marked this pull request as ready for review March 19, 2025 15:32
@TimMenninger TimMenninger force-pushed the tcp-socket-factory-style-fixups branch from 000d120 to 7ba697b Compare March 21, 2025 12:31
@TimMenninger TimMenninger changed the title Docs fixups following #10534 Docs fixups following implement socket factory (#10534) Mar 21, 2025
@TimMenninger TimMenninger force-pushed the tcp-socket-factory-style-fixups branch from 7ba697b to f378fbb Compare March 22, 2025 13:27
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 26, 2025

Thanks @TimMenninger

@bdraco bdraco merged commit 8ac4830 into aio-libs:master Mar 30, 2025
40 checks passed
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Mar 30, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/8ac483068ea24f6a709b3ead51ec87e3660a3b24/pr-10568

Backported as #10637

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2025
bdraco pushed a commit that referenced this pull request Mar 30, 2025
…ocket factory (#10534) (#10637)

**This is a backport of PR #10568 as merged into master
(8ac4830).**

Co-authored-by: Tim Menninger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants