Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.75%. Comparing base (892a4fc) to head (de5c472).
Report is 440 commits behind head on master.

@@            Coverage Diff             @@
##           master   #10371      +/-   ##
==========================================
- Coverage   98.77%   98.75%   -0.03%     
==========================================
  Files         122      122              
  Lines       37038    37048      +10     
  Branches     2041     2042       +1     
==========================================
+ Hits        36585    36587       +2     
- Misses        314      321       +7     
- Partials      139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CodSpeed Performance Report

Merging #10371 will improve performances by 10.57%

_{Comparing jpjacobpadilla:master (de5c472) with master (892a4fc)}

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f46ccff on top of patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371

Backporting merged PR #10371 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371 upstream/3.12

4. Now, cherry-pick PR Added 'partitioned' parameter to set_cookie method. #10371 contents into that branch:

   $ git cherry-pick -x f46ccff6cd0d6043b8dc817f258b5aee8a5a4443

   If it'll yell at you with something like fatal: Commit f46ccff6cd0d6043b8dc817f258b5aee8a5a4443 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x f46ccff6cd0d6043b8dc817f258b5aee8a5a4443

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Added 'partitioned' parameter to set_cookie method. #10371 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

If you could follow the backport instructions, that'd be great.

I should be able to do that! This is my first contribution to aiohttp so I'll have to read through those instructions tonight.