-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[TODO] Finish wiping the attrs usage #5806
Copy link
Copy link
Closed
Labels
HacktoberfestWe think it's good for https://hacktoberfest.digitalocean.com/We think it's good for https://hacktoberfest.digitalocean.com/buggood first issueGood for newcomersGood for newcomersregressionSomething that used to work stopped working "as before" after upgradeSomething that used to work stopped working "as before" after upgradeserver
Description
Describe the bug
Originally, @asvetlov intended to delete any use of attrs from aiohttp 4.0+ series via #5284. He dropped it from the runtime deps too.
But there are some places that still rely on attrs meaning that this will cause failures in runtime because of the missing dep. The tests currently succeed because attrs is listed as a test dep.
One place where it's used is
aiohttp/aiohttp/web_protocol.py
Line 23 in 4d58400
| import attr |
To Reproduce
pip install the recent master w/o the test deps and it should fail
Expected behavior
aiohttp shouldn't rely on deps not declared in the metadata.
Logs/tracebacks
N/APython Version
$ python --versionaiohttp Version
$ python -m pip show aiohttpmultidict Version
$ python -m pip show multidictyarl Version
$ python -m pip show yarlOS
N/A
Related component
Server
Additional context
No response
Code of Conduct
- I agree to follow the aio-libs Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
HacktoberfestWe think it's good for https://hacktoberfest.digitalocean.com/We think it's good for https://hacktoberfest.digitalocean.com/buggood first issueGood for newcomersGood for newcomersregressionSomething that used to work stopped working "as before" after upgradeSomething that used to work stopped working "as before" after upgradeserver