Skip to content

Check the cluster serves the Filestore overlay's CSIDriverConfig API before the step changes anything - #132

Merged
annapendleton merged 1 commit into
mainfrom
filestore-overlay-check
Nov 3, 2026
Merged

annapendleton merged 1 commit into
mainfrom
filestore-overlay-check

Conversation

@aditya-shantanu

Copy link
Copy Markdown
Contributor

The optional Filestore step fails on v1.0.0-rc.1 because upstream's overlay still writes its CSIDriverConfig against ate.dev/v1alpha1 (kubernetes-sigs/gcp-filestore-csi-driver#1416), and it found that out only at the Kustomize apply — after deploy.sh had granted roles/file.editor, the managed addon was turned off, and the namespace was half-applied. The summaries then said "filestore skipped".

  • The script clones the overlay first, reads the apiVersion from its csi_driver_config.yaml, checks it against the served versions of csidriverconfigs.ate.dev, and fails with a message naming both and saying nothing was changed — before any gcloud call. The clone stays at HEAD: no revision of the overlay serves v1 yet, so a pin would only fix the failure in place; the check reads whatever the clone says.
  • Checklist rows follow the new order (fetch, check, addon, IAM, apply); the addon row lights on "nothing to disable".
  • A run that fails and is skipped from the failure sets FilestoreCSIFailed; the completion panel and exit summary say "failed" and point at the namespace, and a successful rerun clears it. README row 8 says what the step checks and that it stops on this pin.

Tests: the check runs as written against a fake kubectl (v1alpha1 vs v1 fails with the full message; v1 passes; both served passes; no CRD fails; non-ate.dev apiVersion fails), script ordering with no gcloud ahead of the check, checklist order and the failed-check stop, the Filestore screen through failure → skip → successful rerun, and the exit summary. gofmt, go vet, full snapshot/steps/state/main and the full ui suite pass (only the known TestFetchTreesFetchesBothCommits fails on this machine). Not verified against a live cluster.

Fixes #114

…before the step changes anything

On a v1.0.0-rc.1 cluster the optional Filestore step failed at "Apply
Kustomize overlay": upstream's overlay writes its CSIDriverConfig against
ate.dev/v1alpha1, and agent-substrate/substrate#2996 moved the CRDs to
ate.dev/v1, which is all the cluster serves. By then deploy.sh had granted
roles/file.editor and bound Workload Identity, the step had turned off the
managed Filestore addon, and the apply had created the namespace,
Deployment and DaemonSet (node pods crash-looping) without the config. The
wizard's [s] moved on and both summaries said "filestore skipped".

The script now clones the overlay first and reads the apiVersion from its
csi_driver_config.yaml, compares it with the served versions of
csidriverconfigs.ate.dev, and fails there — naming both versions, saying
nothing was changed, and pointing at kubernetes-sigs/gcp-filestore-csi-
driver#1416 — before any gcloud call. A cluster without the CRD fails the
same way. The clone stays at HEAD rather than a pin: no revision of the
overlay serves v1 yet, so a pin would only fix the failure in place, while
HEAD picks up the upstream fix when it lands and the check keeps the step
honest until then. The checklist rows follow the new order, and the addon
row lights on "nothing to disable" instead of staying unlit on a cluster
without the managed driver.

A run that fails and is skipped from the failure is recorded
(FilestoreCSIFailed) and reported as "failed" by the completion panel and
the exit summary, which points at the namespace a partial apply leaves
behind; a later run that succeeds clears it. The README row says what the
step checks and that it stops on this pin.

Tests run the check as written against a fake kubectl (v1alpha1 against
v1 fails with the full message, v1 passes, both served passes, no CRD
fails), assert the script's ordering with no gcloud ahead of the check,
cover the checklist order and the failed-check stop, and drive the
Filestore screen through a failure, the skip, and a successful rerun.

Fixes #114

@annapendleton annapendleton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installer: the Filestore CSI step fails on v1.0.0-rc.1 (overlay targets ate.dev/v1alpha1) and leaves IAM and a half-applied namespace behind

2 participants