chore: Realign binary naming & ldflags#99
Merged
ocean merged 6 commits intoahoy-cli:masterfrom Aug 1, 2022
Merged
Conversation
Bring binary naming in Makefile in line with previous releases (i.e. make a bare binary, named with suffixes, not in a tar.gz file). Use Makefile foreach to reduce repetition. Make ldflags more similar to Homebrew Go standard ldflags so binaries downloaded from GH or built with Homebrew are more closely aligned.
Collaborator
|
@ocean However, I cannot find neither tests for producing these binaries nor direct calls to this command in CI + assertions that they were actually created. Is it possible for you to add a behat test to run thanks |
ocean
force-pushed
the
reorganise-makefile
branch
from
0e7b2fb to
064559d
Compare
Member
Author
|
Ok @AlexSkrypnyk - I wrote a BATS test which cross compiles the binaries and then checks to see they exist, good idea 👍 |
ocean
force-pushed
the
reorganise-makefile
branch
from
c0e5fee to
83481eb
Compare
AlexSkrypnyk
approved these changes
Jul 31, 2022
Collaborator
AlexSkrypnyk
left a comment
AlexSkrypnyk
left a comment
There was a problem hiding this comment.
@ocean
Please merge at your earliest convenience.
Member
Author
|
You're allowed to merge too if you want @AlexSkrypnyk 😜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring binary naming in Makefile in line with previous releases
(i.e. make a bare binary, named with suffixes, not in a tar.gz file).
Use Makefile foreach to reduce repetition.
Make
ldflagsmore similar to Homebrew Go standardldflagssobinaries downloaded from GH or built with Homebrew are more
closely aligned.