Repository navigation
Commit aace3b0
fix-huawei-imagereader-166481 (flutter#181931)
Fixes video playback issues on Huawei devices running Android API level
29 or below by falling back to SurfaceTextureSurfaceProducer instead of
ImageReaderSurfaceProducer.
### Problem
On certain Huawei devices with Android 10 (API 29), video playback fails
when using ImageReaderSurfaceProducer. This is due to issues with AHB
(Android Hardware Buffer) imports on these devices, similar to the
Vulkan fallback already implemented in
android_context_dynamic_impeller.cc. Fixes
flutter#166481
### Solution
Added a new JNI method shouldDisableImageReader() that detects Huawei
devices by checking the ro.com.google.clientidbase system property for
the value "android-huawei" when the API level is 29 or below. When this
method returns true, FlutterRenderer.createSurfaceProducer() uses
SurfaceTextureSurfaceProducer instead of ImageReaderSurfaceProducer,
which resolves the video playback issue.
### Changes
FlutterJNI.java: Added shouldDisableImageReader() method and native
bridge
platform_view_android_jni_impl.cc: Native implementation using
__system_property_get() and android_get_device_api_level()
FlutterRenderer.java: Integration in createSurfaceProducer() condition
(line 230)
FlutterRendererTest.java: Unit test for the new behavior
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Reid Baker <[email protected]>
Co-authored-by: Camille Simon <[email protected]>1 parent 48d9be6 commit aace3b0
2 files changed
Lines changed: 47 additions & 1 deletion
File tree
- engine/src/flutter/shell/platform/android
- io/flutter/embedding/engine/renderer
- test/io/flutter/embedding/engine/renderer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
66 | 91 | | |
67 | 92 | | |
68 | 93 | | |
| |||
199 | 224 | | |
200 | 225 | | |
201 | 226 | | |
202 | | - | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
203 | 230 | | |
204 | 231 | | |
205 | 232 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
823 | 825 | | |
824 | 826 | | |
825 | 827 | | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
826 | 845 | | |
827 | 846 | | |
828 | 847 | | |
| |||
0 commit comments