Add fix for typing.Required forward references#544
Merged
agronholm merged 10 commits intoagronholm:masterfrom Feb 6, 2026
Merged
Add fix for typing.Required forward references#544agronholm merged 10 commits intoagronholm:masterfrom
agronholm merged 10 commits intoagronholm:masterfrom
Conversation
Owner
|
This fixes #533, right? If so, please add the appropriate issue link to the changelog entry. |
Contributor
Author
|
That wasn't the original intent but it actually does fix the issue as a side effect :) Added a regression test for that one specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue when using
Requiredforward annotations like this:which cause typeguard to not complain when
fooisn't provided. There's already logic to handleNotRequiredin the same way, this adds the equivalent forRequired.Also fixes #533 (missing inner type validation).
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchYou've updated the documentation (indocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #999, the entry should look like this:
* Fix big bad boo-boo in the pytest plugin (#999 <https://github.com/agronholm/typeguard/issues/999>_; PR by @yourgithubaccount)If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.