Fixed protocol check failing for inherited class/static methods#542
Merged
agronholm merged 2 commits intoagronholm:masterfrom Feb 6, 2026
Merged
Fixed protocol check failing for inherited class/static methods#542agronholm merged 2 commits intoagronholm:masterfrom
agronholm merged 2 commits intoagronholm:masterfrom
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
force-pushed
the
master
branch
from
4a0c974 to
79a687a
Compare
Owner
|
Yeah, I'll try to get around it today or tomorrow. Should go into the next release if it's OK. |
agronholm
approved these changes
Feb 6, 2026
Owner
agronholm
left a comment
agronholm
left a comment
There was a problem hiding this comment.
Seems simple enough. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #539.
When checking if a class implements a protocol with a
classmethodorstaticmethod, typeguard only looked at the class's own__dict__and missed inherited methods. This caused subclasses to fail protocol checks even when they properly inherit the requiredclassmethodfrom a parent. The fix traverses the MRO to find where the method is actually defined.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).