Fix tests to work on Windows.#488
Merged
agronholm merged 1 commit intoagronholm:masterfrom Sep 21, 2024
thetorpedodog:wait-what-people-actually-use-windows
Merged
Fix tests to work on Windows.#488agronholm merged 1 commit intoagronholm:masterfrom thetorpedodog:wait-what-people-actually-use-windows
agronholm merged 1 commit intoagronholm:masterfrom
thetorpedodog:wait-what-people-actually-use-windows
Conversation
A few tests fail on a clean checkout on Windows due to formatting differences (CRLF newlines and \ in filenames). These should now pass on both Windows and Unix/Linux platforms.
Owner
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A few tests fail on a clean checkout on Windows due to formatting differences (CRLF newlines and \ in filenames). These should now pass on both Windows and Unix/Linux platforms.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patch(these are the tests that are already there!)
docs/, in case of behavior changes or new features)(no behavior changes or new features)
docs/versionhistory.rst).(trivial)