Assume that typing_extensions is always installed.#487
Merged
agronholm merged 1 commit intoagronholm:masterfrom Sep 21, 2024
thetorpedodog:always-typing-extensions
Merged
Assume that typing_extensions is always installed.#487agronholm merged 1 commit intoagronholm:masterfrom thetorpedodog:always-typing-extensions
agronholm merged 1 commit intoagronholm:masterfrom
thetorpedodog:always-typing-extensions
Conversation
Because we strictly depend upon typing_extensions both explicitly and implicitly, we don't need the code which checks if it isn't installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Because we strictly depend upon typing_extensions both explicitly and implicitly, we don't need the code which checks if it isn't installed.
(This is a precursor to work on #479)
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.