Handle missing branches in BinOp (#392)

vthemelis · agronholm · web-flow · commit 041b0e3fc165 · 2023-09-03T16:46:58.000+03:00
Co-authored-by: Alex Grönholm &lt;alex.gronholm@nextday.fi&gt;
diff --git a/docs/versionhistory.rst b/docs/versionhistory.rst
@@ -3,6 +3,11 @@ Version history
 
 This library adheres to `Semantic Versioning 2.0 <https://semver.org/#semantic-versioning-200>`_.
 
+**UNRELEASED**
+
+- Fixed ``AttributeError`` where the transformer removed elements from a PEP 604 union
+  (`#384 <https://github.com/agronholm/typeguard/issues/384>`_)
+
 **4.1.3** (2023-08-27)
 
 - Dropped Python 3.7 support
diff --git a/src/typeguard/_transformer.py b/src/typeguard/_transformer.py
@@ -375,6 +375,16 @@ def visit_BinOp(self, node: BinOp) -> Any:
         self.generic_visit(node)
 
         if isinstance(node.op, BitOr):
+            # If either branch of the BinOp has been transformed to `None`
+            # then the `ast.generic_visit` will eliminate that branch completely.
+            # If this happens, treat the BinOp as just the other branch.
+            if not hasattr(node, "left") and not hasattr(node, "right"):
+                return None
+            elif not hasattr(node, "left"):
+                return node.right
+            elif not hasattr(node, "right"):
+                return node.left
+
             # Return Any if either side is Any
             if self._memo.name_matches(node.left, *anytype_names):
                 return node.left
diff --git a/tests/test_transformer.py b/tests/test_transformer.py
@@ -1570,6 +1570,37 @@ def foo(x: str) -> None:
     )
 
 
+def test_union_annotation_with_or_operator() -> None:
+    node = parse(
+        dedent(
+            """
+            from __future__ import annotations
+
+            class A:
+                ...
+
+            def foo(A: A | None) -> None:
+                pass
+            """
+        )
+    )
+    TypeguardTransformer(["foo"]).visit(node)
+    assert (
+        unparse(node)
+        == dedent(
+            """
+            from __future__ import annotations
+
+            def foo(A: A | None) -> None:
+                from typeguard import TypeCheckMemo
+                from typeguard._functions import check_argument_types
+                memo = TypeCheckMemo(globals(), locals())
+                check_argument_types('foo', {'A': (A, None)}, memo)
+            """
+        ).strip()
+    )
+
+
 def test_dont_parse_annotated_2nd_arg() -> None:
     # Regression test for #352
     node = parse(
