Repository navigation
Conversation
Fixes #1364. When an enclosing cancel scope was cancelled after a connection attempt succeeded but before the task group exited, the connected stream was dropped without being closed. Close it forcefully on the BaseException path.
Contributor
Author
|
Friendly bump on this when you have a moment. CI is green, and I'm happy to adjust anything you'd like changed. |
Owner
|
Why did you close the PR? |
Contributor
Author
|
Sorry, this was closed by mistake, reopening. |
Owner
|
I have tons of PRs to review and a change to the changelog update procedure in the works, so I don't know when I'll get around to this one. Hopefully not too long. |
…cel-socket-leak # Conflicts: # docs/versionhistory.rst
charan-rathore
added a commit
to charan-rathore/charan-rathore
that referenced
this pull request
Oct 10, 2026
Contributor
|
It would be lovely to see a release with this fix in it; is there a release scheduled any time soon? Thanks for all your work on |
Owner
|
Yes. Check the milestone for remaining PRs/issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!
Changes
Fixes #1364.
When
connect_tcp()is called inside a cancel scope that gets cancelled after one of the connection attempts has succeeded but before the internal task group exits, the winningSocketStreamwas dropped without being closed, leaking a connected socket. This adds aBaseExceptionhandler that forcefully closes the connected stream before re-raising.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.
Testing notes: the new test (
test_connect_tcp_closes_winner_on_outer_cancellation) fails without the patch and passes with it on asyncio, asyncio+uvloop and Trio backends. Fullpytest tests/run with the patch: 4253 passed, 6 failed; all 6 failures (TLS certificate check variants intest_sockets.py) also fail identically on unmodified upstream source in this environment, so they are unrelated to this change.