fix: in activate bash output, wrap mise executable path in single-quotes (jdx#7002)

cspotcode · web-flow · commit 4a9ec4e1d476 · 2025-11-18T00:57:02.000-06:00
On Windows, the path to `mise.exe` will contain backslashes. Both `busybox.exe bash` and Git-for-Windows' "Git Bash" can understand these backslash paths. But bash syntax rules dictate that unquoted backslashes are interpreted as escapes. We must wrap the path in single-quotes to avoid this. ```bash # In "Git Bash" or "busybox.exe bash" # Backslash paths are accepted $ 'G:\dev\@jdx\mise\target\debug\mise.exe' --version ... 2025.11.5-DEBUG windows-x64 (2025-11-18) # But unqouted is broken # because bash's syntax rules will interpret any unquoted backslashes as escapes $ G:\dev\@jdx\mise\target\debug\mise.exe --version bash: G:dev@jdxmisetargetdebugmise.exe: not found ``` Quoting is *technically* more correct on Linux, too, even though the issues it avoids -- splitting on spaces -- are largely hypothetical.[^1] I can't think of any way that this code change would break someone's legitimate setup on Linux or Mac. [^1]: To be pedantic, if the path to `mise` includes a single-quote -- if the name of a parent directory has a single-quote in it -- then this will be broken on Linux, but it would *already* be broken before this code change, so we are not making it worse.
diff --git a/src/shell/bash.rs b/src/shell/bash.rs
@@ -38,7 +38,7 @@ impl Shell for Bash {
               local command
               command="${{1:-}}"
               if [ "$#" = 0 ]; then
-                command {exe}
+                command '{exe}'
                 return
               fi
               shift
@@ -47,12 +47,12 @@ impl Shell for Bash {
               deactivate|shell|sh)
                 # if argv doesn't contains -h,--help
                 if [[ ! " $@ " =~ " --help " ]] && [[ ! " $@ " =~ " -h " ]]; then
-                  eval "$(command {exe} "$command" "$@")"
+                  eval "$(command '{exe}' "$command" "$@")"
                   return $?
                 fi
                 ;;
               esac
-              command {exe} "$command" "$@"
+              command '{exe}' "$command" "$@"
             }}
 
             _mise_hook() {{
@@ -85,7 +85,7 @@ impl Shell for Bash {
                 fi
 
                 command_not_found_handle() {{
-                    if [[ "$1" != "mise" && "$1" != "mise-"* ]] && {exe} hook-not-found -s bash -- "$1"; then
+                    if [[ "$1" != "mise" && "$1" != "mise-"* ]] && '{exe}' hook-not-found -s bash -- "$1"; then
                       _mise_hook
                       "$@"
                     elif [ -n "$(declare -f _command_not_found_handle)" ]; then
diff --git a/src/shell/snapshots/mise__shell__bash__tests__activate.snap b/src/shell/snapshots/mise__shell__bash__tests__activate.snap
@@ -14,7 +14,7 @@ mise() {
   local command
   command="${1:-}"
   if [ "$#" = 0 ]; then
-    command /some/dir/mise
+    command '/some/dir/mise'
     return
   fi
   shift
@@ -23,12 +23,12 @@ mise() {
   deactivate|shell|sh)
     # if argv doesn't contains -h,--help
     if [[ ! " $@ " =~ " --help " ]] && [[ ! " $@ " =~ " -h " ]]; then
-      eval "$(command /some/dir/mise "$command" "$@")"
+      eval "$(command '/some/dir/mise' "$command" "$@")"
       return $?
     fi
     ;;
   esac
-  command /some/dir/mise "$command" "$@"
+  command '/some/dir/mise' "$command" "$@"
 }
 
 _mise_hook() {
@@ -77,7 +77,7 @@ if [ -z "${_mise_cmd_not_found:-}" ]; then
     fi
 
     command_not_found_handle() {
-        if [[ "$1" != "mise" && "$1" != "mise-"* ]] && /some/dir/mise hook-not-found -s bash -- "$1"; then
+        if [[ "$1" != "mise" && "$1" != "mise-"* ]] && '/some/dir/mise' hook-not-found -s bash -- "$1"; then
           _mise_hook
           "$@"
         elif [ -n "$(declare -f _command_not_found_handle)" ]; then
