Repository navigation
[fix] Resolve N1N model strings - #7948
Merged
Merged
Conversation
ysolanky
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
n1nprovider mapping toagno.models.utils.get_model()so model-string paths such asAgent(model="n1n:gpt-4o")resolve to the existingN1Nprovider.Related to #5036.
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Duplicate and AI-Generated PR Check
Additional Notes
Focused validation run from
libs/agnousing a minimal local venv becauseuv run --extra dev pytest tests/unit/utils/test_model_string.pycould not resolve all package extras in this environment (brave-searchanda2a-sdkrequire incompatiblehttpxversions across supported Python splits).Validation passed:
TMPDIR=/home/ubuntu/gh-pr/agno-worker-next/.tmp .venv/bin/python -m pytest -p no:cacheprovider tests/unit/utils/test_model_string.pyTMPDIR=/home/ubuntu/gh-pr/agno-worker-next/.tmp .venv/bin/python -m pytest -p no:cacheprovider tests/unit/models/test_n1n.py.venv/bin/ruff format --check agno/models/utils.py tests/unit/utils/test_model_string.py.venv/bin/ruff check agno/models/utils.py tests/unit/utils/test_model_string.pygit diff --check