Repository navigation
fix(scheduler): notify owner after deleting schedules - #3103
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope Version
2.0.10dev, based onmainat72f3f6fa0b2fc38b8517f408ab616f0f2bd229e6.Description
Deleting a schedule through
ScheduleDeleteon a node with scheduling disabled removes the storage record but leaves the timer owner's job until periodic reconciliation. Pass the existingSchedulerManagerto the internal tool and callnotify_changed()after a successful deletion, matching the HTTP deletion path and preserving best-effort notification behavior.Add six regressions for notification ordering, owner/non-owner deletion, missing records, storage failure, and notification failure. The owner tests consume lifecycle notifications rather than calling reconciliation manually after deletion. Public tool inputs and application configuration remain the same.
Fixes #3102
Validation
pytest tests/service_scheduler_test.py tests/schedule_router_test.py tests/service_toolkit_test.py -q— 36 passed.pre-commit run --all-files— passed.The lifecycle regressions use fakeredis-backed storage and message bus instances. Live service integration and deployment across separate processes have not been tested. Notifications do not provide an atomic stop guarantee for an already running callback.
Checklist