Skip to content

clean up build directory after pip install in Dockerfile#3638

Merged
xieyxclack merged 1 commit intoagentscope-ai:mainfrom
ideal:main
Apr 27, 2026
Merged

clean up build directory after pip install in Dockerfile#3638
xieyxclack merged 1 commit intoagentscope-ai:mainfrom
ideal:main

Conversation

@ideal
Copy link
Copy Markdown
Contributor

@ideal ideal commented Apr 21, 2026 •
edited
Loading

Description

Remove build directory to prevent it stay in Docker image.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Core / Backend (app, agents, config, providers, utils, local_models)
  • Console (frontend web UI)
  • Channels (DingTalk, Feishu, QQ, Discord, iMessage, etc.)
  • Skills
  • CLI
  • Documentation (website)
  • Tests
  • CI/CD
  • Scripts / Deploy

Checklist

  • I ran pre-commit run --all-files locally and it passes
  • If pre-commit auto-fixed files, I committed those changes and reran checks
  • I ran tests locally (pytest or as relevant) and they pass
  • Documentation updated (if needed)
  • Ready for review

For Channel Changes (DingTalk, Feishu, QQ, Console, etc.)

  • I ran ./scripts/check-channels.sh (or ./scripts/check-channels.sh --changed) and it passes
  • Contract test exists in tests/contract/channels/test_<channel>_contract.py (REQUIRED)
  • Contract test implements create_instance() with proper channel initialization
  • All 19 contract verification points pass (see tests/contract/channels/__init__.py)
  • Optional: Unit tests in tests/unit/channels/test_<channel>.py for complex internal logic

Testing

Build Docker image again and find that /app/build not exists.

Local Verification Evidence

pre-commit run --all-files
# paste summary result

pytest
# paste summary result

Additional Notes

[Optional: any other context]

@github-project-automation github-project-automation Bot moved this to Todo in QwenPaw Apr 21, 2026
@github-actions github-actions Bot added the first-time-contributor PR created by a first time contributor label Apr 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Welcome to QwenPaw! 🐾

Hi @ideal, thank you for your first Pull Request! 🎉

🙌 Join Developer Community

Thanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page:
https://qwenpaw.agentscope.io/docs/community

We truly appreciate your enthusiasm—and look forward to your future contributions! 😊

We'll review your PR soon.

Tip

⭐ If you find QwenPaw useful, please give us a Star!

Star QwenPaw

Staying ahead

Star QwenPaw on GitHub and be instantly notified of new releases.

Your star helps more developers discover this project! 🐾

@xieyxclack
Copy link
Copy Markdown
Member

xieyxclack commented Apr 24, 2026

Hi @ideal, thanks for the PR!

Since PR #3698 has been merge, the Dockerfile now uses uv pip install instead of pip install. uv builds in an isolated temp directory via PEP 517, so no build/ directory is created under /app/ — the cleanup is no longer needed.

@ideal ideal closed this Apr 24, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in QwenPaw Apr 24, 2026
@ideal
Copy link
Copy Markdown
Contributor Author

ideal commented Apr 24, 2026

@xieyxclack I tried and because of build-backend = "setuptools.build_meta", it still had build dir after running uv pip install --no-cache-dir ..

@ideal ideal reopened this Apr 24, 2026
@xieyxclack
Copy link
Copy Markdown
Member

xieyxclack commented Apr 27, 2026

@ideal Please resolve the conflict

@yuanxs21 Could you help test this pr?

@xieyxclack xieyxclack requested a review from yuanxs21 April 27, 2026 09:21
@yuanxs21
Copy link
Copy Markdown
Collaborator

yuanxs21 commented Apr 27, 2026

@ideal Please resolve the conflict

@yuanxs21 Could you help test this pr?

Ok~I'll test this pr locally.

yuanxs21
yuanxs21 reviewed Apr 27, 2026
View reviewed changes
Comment thread deploy/Dockerfile Outdated
yuanxs21
yuanxs21 reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@yuanxs21 yuanxs21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the inline review.

@xieyxclack xieyxclack merged commit f7811f3 into agentscope-ai:main Apr 27, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Welcome to QwenPaw! 🎉

Thank you @ideal for your first contribution! Your PR has been merged. 🚀

We'd love to give you a shout-out in our release notes! If you're comfortable sharing, please reply to this comment with your social media handles using the format below:

discord: your_discord_handle
x: your_x_handle
xiaohongshu: your_xiaohongshu_id

Note: Only share what you're comfortable with — all fields are optional.

Thanks again for helping make QwenPaw better!

@xieyxclack
Copy link
Copy Markdown
Member

xieyxclack commented Apr 27, 2026

@ideal @yuanxs21 Thank you for your contribution!

cofly-io pushed a commit to cofly-io/xClaw that referenced this pull request Apr 29, 2026
@ideal @cofly-io
perf(docker): clean up build directory after pip install (agentscope-…
c86d56c 
…ai#3638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuanxs21 yuanxs21 yuanxs21 approved these changes

Assignees

No one assigned

Labels

first-time-contributor PR created by a first time contributor Under Review

Projects

QwenPaw
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ideal @xieyxclack @yuanxs21