fix: update lint Makefile target to use system golangci-lint#411
Open
Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Open
fix: update lint Makefile target to use system golangci-lint#411Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Conversation
Fixes agentregistry-dev#377 After PR agentregistry-dev#253 removed golangci-lint from Go tools, make lint fails with 'go: no such tool golangci-lint'. Update the GOLANGCI_LINT variable to use the system-installed binary instead of go tool, and add a pre-flight check with an install link on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377
Summary
After PR #253 removed golangci-lint from Go tools,
make lintfails with:Fix
Update
GOLANGCI_LINTvariable to use the system-installedgolangci-lintbinary instead ofgo tool golangci-lint. Add a pre-flight check that prints an install link if the binary is not found.This matches the CI approach in
.github/workflows/lint.ymlwhich uses thegolangci/golangci-lint-action.Test plan
make lintworks with system-installed golangci-lintmake lintprints helpful error if golangci-lint is not installed