ci: Remove --fix flag from golangci-lint#389
ci: Remove --fix flag from golangci-lint#389timflannagan merged 3 commits intoagentregistry-dev:mainfrom
Conversation
Signed-off-by: timflannagan <[email protected]>
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
Signed-off-by: timflannagan <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the CI lint workflow to stop running golangci-lint in auto-fix mode, ensuring lint issues are surfaced as CI failures rather than silently rewritten during the workflow run.
Changes:
- Removed the
--fixargument from thegolangci/golangci-lint-actionstep in the Go lint job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
1 similar comment
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
timflannagan
force-pushed
the
chore/lint-fixes
branch
from
ba2f303 to
d509714
Compare
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
Testing #390. Closing & re-opening. |
Description
Fixes #388. Removes the --fix flag argument from the lint.yaml workflow. See https://github.com/agentregistry-dev/agentregistry/actions/runs/23316189823/job/67816197314?pr=389 which proves this fixes the issue. The secondary commit fixes the linting violations via running
go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --fixand committing the results.Change Type
/kind cleanup
Changelog
Additional Notes