Conversation
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds a new top-level arctl deployments command (alias: arctl deploy) to manage agent and MCP deployments from a single command group, moving prior per-resource deploy functionality under deployments create and introducing additional deployment management subcommands.
Changes:
- Registers a new
deployments/deploycommand group withcreate,list,show, anddeletesubcommands, and wires it into the CLI root with API client injection. - Removes the legacy
arctl agent deployandarctl mcp deploycommands and updates command-tree tests accordingly. - Updates e2e coverage to use
deploy createand adds a basicdeploy listverification after deployment creation.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/root.go | Wires the new deployments command group into the root CLI and passes the API client. |
| pkg/cli/commands_test.go | Updates expected command tree to include deployments and adjusts subcommand counts. |
| internal/cli/mcp/mcp.go | Removes registration of the legacy mcp deploy subcommand. |
| internal/cli/mcp/deploy.go | Deletes the legacy MCP deploy command implementation (moved under deployments). |
| internal/cli/deployment/deployment.go | Introduces the deployments command group and registers subcommands. |
| internal/cli/deployment/create.go | Implements deployments create for agent/MCP deployments (moved/merged logic). |
| internal/cli/deployment/create_test.go | Moves/renames tests to match the new deployment package and helper names. |
| internal/cli/deployment/list.go | Implements deployments list with filters and redaction. |
| internal/cli/deployment/show.go | Implements deployments show with table/JSON output and redaction. |
| internal/cli/deployment/delete.go | Implements deployments delete and ID prefix resolution. |
| internal/cli/agent/deploy.go | Deletes the legacy agent deploy command implementation (moved under deployments). |
| internal/cli/agent/agent.go | Removes registration of the legacy agent deploy subcommand. |
| e2e/deploy_test.go | Updates e2e flows to use deploy create and verifies deploy list includes the new deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
Signed-off-by: Peter Jausovec <[email protected]>
Signed-off-by: Peter Jausovec <[email protected]>
Signed-off-by: Peter Jausovec <[email protected]>
peterj
force-pushed
the
peterj/adddeploymentscommand
branch
from
280c521 to
6ab7895
Compare
Description
adds the
arctl deploycommand -- thearctl [mcp/agent] deployfunctionality is not inarctl deploy createcommand. This is the same functionality, just moved to another command.The additional commands that were added:
arctl deploy list-- lists all deployments (managed and discovered)arctl deploy delete-- deletes a deployment by IDarctl deploy show-- shows the details of a deployment (including the URL if it's a local deployment)Change Type
Changelog
Additional Notes
The docs PR is here.