charts: Add missing kagent RBAC permissions#329
Merged
timflannagan merged 1 commit intoagentregistry-dev:mainfrom Mar 12, 2026
Merged
charts: Add missing kagent RBAC permissions#329timflannagan merged 1 commit intoagentregistry-dev:mainfrom
timflannagan merged 1 commit intoagentregistry-dev:mainfrom
Conversation
Fixes agentregistry-dev#325. See issue description for reproducer. Signed-off-by: timflannagan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm chart RBAC for the agentregistry deployment by granting missing permissions needed to list/watch kagent.dev resources used during Kubernetes discovery (per Issue #325).
Changes:
- Extend
kagent.devRBAC rules to includeagentsandremotemcpserversalongside existingmcpservers. - Update Helm unit tests to assert the new RBAC resources are present in both default and
rbac.watchedNamespacesmodes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/agentregistry/templates/rbac.yaml | Adds agents and remotemcpservers to the chart’s kagent.dev RBAC resources in both ClusterRole and per-namespace Role variants. |
| charts/agentregistry/tests/rbac_test.yaml | Updates assertions to validate the expanded kagent.dev RBAC resource list in rendered manifests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shashankram
approved these changes
Mar 12, 2026
nikolasmatt
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #325. See issue description for reproducer. Manually tested locally since we don't have the helm chart hooked up to CI yet.
Change Type
/kind fix
Changelog
Additional Notes