resolving prompts when deploying locally & to k8s#319
Merged
Conversation
Signed-off-by: Peter Jausovec <[email protected]>
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds “prompt resolution” to the registry-driven deployment flow so that agents deployed locally (Docker) or to Kubernetes can receive a concrete prompts.json generated from prompt references in agent.yaml (issue #308).
Changes:
- Add a
ResolveAgentManifestPromptsAPI onRegistryService, plus fake implementation support for tests. - Extend the resolved agent config/types to carry
ResolvedPromptdata, and wire it into local + Kubernetes deployment adapters (writingprompts.json). - Add/extend unit tests for local + Kubernetes translation, plus a new e2e test covering deploy-with-prompts.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/registry/service/testing/fake_registry.go | Adds fake hook + method for resolving manifest prompts in tests. |
| internal/registry/service/service.go | Extends RegistryService interface with ResolveAgentManifestPrompts. |
| internal/registry/service/registry_service.go | Implements prompt resolution from manifest prompt refs to concrete prompt content. |
| internal/registry/platforms/utils/deployment_adapter_utils.go | Resolves prompts during agent resolution; adds helper to convert to Python prompt config format. |
| internal/registry/platforms/types/types.go | Adds ResolvedPrompt type and fields on agent/resolved config to carry prompts. |
| internal/registry/platforms/local/deployment_adapter_local.go | Writes/cleans up prompts config alongside MCP config during deploy/undeploy. |
| internal/registry/platforms/local/deployment_adapter_local_test.go | Adds tests asserting prompts config refresh is called on deploy/undeploy. |
| internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform.go | Includes prompts in agent ConfigMap + volume items; writes prompts.json when present. |
| internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go | Adds translation tests for prompts-only and prompts+MCP cases. |
| e2e/deploy_test.go | Adds e2e test deploying an agent that references a registry prompt and verifying prompts.json presence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform.go
Show resolved
Hide resolved
…ests Signed-off-by: Peter Jausovec <[email protected]>
timflannagan
approved these changes
Mar 13, 2026
Signed-off-by: Peter Jausovec <[email protected]>
timflannagan
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves the prompts when deploying locally and to kubernetes. Fixes #308 and #315
Change Type
Changelog