feature(helm): charts followup by frivas-at-navteca · Pull Request #297 · agentregistry-dev/agentregistry

frivas-at-navteca · 2026-03-06T14:16:29Z

Description

This is a follow up to PR #245. This PR addresses the suggestions from @peterj and @timflannagan. This continues the implementation of #242. This PR includes 2 new workflows one to test and another to create a release of the chart. The set of targets in the Makefile just for the charts. I have tried to be very careful on messing with something else.

I want to bring to your attention a couple things:

There are variables that need to be set for the workflow to work (I can change them if needed):

HELM_REGISTRY_PASSWORD
HELM_REGISTRY
HELM_REGISTRY_USERNAME
HELM_REPO

In our tests we have noticed that you always need kMCP (CRDs and the tool itself). We initially through it was kAgent but we narrowed it down to kMCP so Agent Registry can actually created the pod. We tested with just the CRDs, the MCP is deployed but no pod is created, with the tool itself it seems to work correctly.

Shall I add kMCP as a dependency of the Agent Registry chart and also create a section in the values.yaml in which it can be enabled and configured? otherwise administrators will have to do this separately and it seems the documentation is not including this information.

Change type

/kind cleanup

Changelog

Adding a Helm Chart

…new workflows that will run the Helm Chart Tests and also make a release.

Copilot

Pull request overview

This PR is a follow-up to #245 (adding a Helm chart for Agent Registry). It addresses reviewer feedback by bumping the Agent Registry image tag to 0.2.1, switching the default pgvector tag from a versioned format (0.8.2-pg17) to a shorter floating format (pg16), adding Makefile targets for chart operations (lint, package, push, test), and introducing two GitHub Actions workflows: one for CI chart testing and one for releasing the chart to GHCR via OCI.

Changes:

Default images updated: Agent Registry 0.2.0→0.2.1; pgvector tag format changed from 0.8.2-pg17 to pg16
New Makefile Helm targets (charts-deps, charts-lint, charts-package, charts-push, charts-test, charts-all) with configurable variables
Two new GitHub Actions workflows: chart-tests.yml (CI lint + unit tests) and chart-release.yml (package and publish to GHCR on GitHub Release)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`charts/agentregistry/values.yaml`	Bumps `image.tag` to `0.2.1`; changes pgvector default tag to `pg16` with updated comments
`charts/agentregistry/tests/postgresql_test.yaml`	Updates test assertions to reflect the new `pg16` default tag
`charts/agentregistry/Chart.yaml`	Bumps chart version to `0.3.3`; updates `artifacthub.io/images` to reference `0.2.1` and `pg16`
`Makefile`	Adds Helm variables and six chart-related phony targets
`.github/workflows/chart-tests.yml`	New workflow to lint and unit-test the chart on push/PR
`.github/workflows/chart-release.yml`	New workflow to package and publish the chart to GHCR on a GitHub Release event

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

charts/agentregistry/values.yaml

Makefile

.github/workflows/chart-release.yml

charts/agentregistry/Chart.yaml

.github/workflows/chart-release.yml

.github/workflows/chart-tests.yml

charts/agentregistry/Chart.yaml

Makefile

Co-authored-by: Copilot <[email protected]>

…is test needed to be changed because is not scalable.

nikolasmatt

Thanks for the contribution and the rapid iterations on this work! I left a few comments for improvements primarily themed around release coordination and code-reuse between workflows and local.

.github/workflows/chart-release.yml

.github/workflows/chart-tests.yml

nikolasmatt · 2026-03-06T16:45:08Z

.github/workflows/chart-tests.yml

@@ -0,0 +1,99 @@
+name: Chart Tests


review this workflow after creating the make targets i noted on the release workflow.

charts/agentregistry/values.yaml

Makefile

frivas-at-navteca · 2026-03-06T18:12:41Z

Thanks for the contribution and the rapid iterations on this work! I left a few comments for improvements primarily themed around release coordination and code-reuse between workflows and local.

Thank you very. I appreciate the time and your comments. I will address them.

…and the Relase. Pin an immutable tag for pgvector. Using make targets for repeatable tasks.

frivas-at-navteca added 3 commits March 6, 2026 14:04

Setting pg16 as the default version for pgvector

4b5b17b

Adding a set of targets for the Helm Chart to the Makefile. Adding 2 …

a4cbf91

…new workflows that will run the Helm Chart Tests and also make a release.

Bump to default version

01a6771

Copilot AI review requested due to automatic review settings March 6, 2026 14:16

Copilot started reviewing on behalf of frivas-at-navteca March 6, 2026 14:17 View session

github-actions bot added do-not-merge/kind-invalid do-not-merge/release-note-invalid labels Mar 6, 2026

Copilot AI reviewed Mar 6, 2026

View reviewed changes

frivas-at-navteca and others added 10 commits March 6, 2026 14:24

Removing the verify flag that makes helm unittest to fail

584c7ac

Update charts/agentregistry/values.yaml

898e415

Co-authored-by: Copilot <[email protected]>

Update charts/agentregistry/values.yaml

1f00512

Co-authored-by: Copilot <[email protected]>

Update charts/agentregistry/Chart.yaml

01cfba1

Co-authored-by: Copilot <[email protected]>

Update charts/agentregistry/Chart.yaml

e20ac7a

Co-authored-by: Copilot <[email protected]>

Update .github/workflows/chart-tests.yml

8fcf458

Co-authored-by: Copilot <[email protected]>

Update charts/agentregistry/Chart.yaml

fd4caa8

Co-authored-by: Copilot <[email protected]>

Removing an unknown flag for helm unittest

e338066

Fixing tests and workflow failing because server version mismatch, th…

2d3f241

…is test needed to be changed because is not scalable.

Fixing the regex to match SHA digest of the server version

4c8d67b

nikolasmatt mentioned this pull request Mar 6, 2026

test(helm) - add helm unit tests to CI check #289

Closed

nikolasmatt reviewed Mar 6, 2026

View reviewed changes

frivas-at-navteca added 4 commits March 9, 2026 10:59

Adding .PHONY to each target in Makefile. Unifying the Chart Release …

3f7878c

…and the Relase. Pin an immutable tag for pgvector. Using make targets for repeatable tasks.

Merge branch 'main' into feature/charts-followup

0c753f3

Fixing the Makefile duw to issues installing the helm-unittest plugin

a38a871

Removing unnecessary reference to chart-release

1499b71

frivas-at-navteca changed the title ~~Feature/charts followup~~ feature(helm): charts followup Mar 9, 2026

github-actions bot added kind/cleanup release-note and removed do-not-merge/kind-invalid do-not-merge/release-note-invalid labels Mar 9, 2026

nikolasmatt approved these changes Mar 9, 2026

View reviewed changes

peterj approved these changes Mar 9, 2026

View reviewed changes

peterj added this pull request to the merge queue Mar 9, 2026

Merged via the queue into agentregistry-dev:main with commit d94bd23 Mar 9, 2026
12 of 16 checks passed

frivas-at-navteca deleted the feature/charts-followup branch March 12, 2026 13:19

Conversation

frivas-at-navteca commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change type

Changelog

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikolasmatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikolasmatt Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frivas-at-navteca commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

frivas-at-navteca commented Mar 6, 2026 •

edited

Loading