fix: handle transient network errors in PyPI validation test#295
Conversation
|
can you update the PR template |
peterj
left a comment
peterj
left a comment
There was a problem hiding this comment.
please update the pr template
Network-bound test cases now handle transient errors (timeout, DNS failure, connection refused) gracefully instead of failing the test suite. Non-existent package tests accept network errors as valid failures since both outcomes prove the package cannot be validated. Fixes agentregistry-dev#194 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
1 similar comment
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
github-actions
bot
added
kind/fix
release-note
and removed
do-not-merge/description-invalid
do-not-merge/kind-invalid
do-not-merge/release-note-invalid
labels
|
Updated the PR template and rebased on latest main. Only |
|
PR template has been updated to follow the standard format (Description, Change Type, Changelog, Additional Notes). Ready for re-review. |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
Updated PR description to match the template. Ready for re-review. |
613a378
2 participants
Description
networkBoundandallowNetErrorflags to test cases that depend on PyPI being reachableisNetworkErrorhelper that checks for common transient error patterns (timeout, DNS, connection refused, TLS handshake)Change Type
/kind flake
Changelog
Additional Notes
internal/registry/validators/registries/pypi_test.gois changed.