fix: use user-provided name for MCP server k8s resources#284
Merged
peterj merged 1 commit intoagentregistry-dev:mainfrom Mar 7, 2026
Merged
Conversation
…ry-dev#146) When an agent.yaml specifies a `name` for a registry-type MCP server, that name is now used as the Kubernetes service/resource name instead of the full registry server name (e.g. "my-mcp-server" instead of "user-my-mcp-server"). This ensures the k8s service name matches what gets written to mcp-servers.json, so the agent can actually connect to its MCP servers. - Add Name field to MCPServerRunRequest for user-provided name override - Populate it from mcpServer.Name in resolveAgentManifestMCPServers - Use it in both translateRemoteMCPServer and translateLocalMCPServer - Use it in createResolvedMCPServerConfigs for mcp-servers.json Co-Authored-By: Claude Opus 4.6 <[email protected]>
peterj
approved these changes
Mar 6, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
agentregistry-dev:main
with commit Mar 7, 2026
8cb6c14
8 of 10 checks passed
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
…ry-dev#284) # Description - When `agent.yaml` specifies a `name` for a registry-type MCP server (e.g. `name: my-mcp-server`), that name is now used as the k8s service/resource name instead of the full registry name (`user/my-mcp-server` → `user-my-mcp-server`) - Ensures the k8s service name matches what gets written to `mcp-servers.json`, allowing the agent to connect - Falls back to registry server name when no user-provided name is set (backward compatible) Fixes agentregistry-dev#146 # Change Type ``` /kind fix ``` # Changelog ```release-note use user-provided name for MCP server (not the registry name) ``` ## Test plan - [x] New unit test: `TestCreateResolvedMCPServerConfigs_UsesUserProvidedName` - [x] Existing tests pass unchanged - [x] Build succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agent.yamlspecifies anamefor a registry-type MCP server (e.g.name: my-mcp-server), that name is now used as the k8s service/resource name instead of the full registry name (user/my-mcp-server→user-my-mcp-server)mcp-servers.json, allowing the agent to connectFixes #146
Change Type
Changelog
Test plan
TestCreateResolvedMCPServerConfigs_UsesUserProvidedName🤖 Generated with Claude Code