Skip to content

fix: remove empty Website column from skill list output#269

Merged
peterj merged 3 commits intoagentregistry-dev:mainfrom
optimus-fulcria:fix/skill-list-cleanup
Mar 6, 2026
Merged

fix: remove empty Website column from skill list output#269
peterj merged 3 commits intoagentregistry-dev:mainfrom
optimus-fulcria:fix/skill-list-cleanup

Conversation

@optimus-fulcria
Copy link
Copy Markdown
Contributor

@optimus-fulcria optimus-fulcria commented Mar 5, 2026

Description

Remove uninformative columns from arctl skill list output and add useful ones.

Motivation: The Website column was always empty and the Category column provided little value. Type and Source give users actionable information about where a skill comes from.

What changed:

  • Removed empty Website column
  • Removed Category column (per review feedback)
  • Added Type column showing registryType (docker/oci/npm) or repository source (github)
  • Added Source column showing package identifier or repository URL

Change Type

/kind fix

Changelog

Show Type and Source columns instead of Category and Website in skill list output

Additional Notes

Uses Packages[0].RegistryType / Packages[0].Identifier for package-based skills and Repository.Source / Repository.URL for GitHub-published skills, falling back to <none> when neither is set.

Unit test added for the skillSource helper with four cases: package source, repository source, package precedence, and no-source fallback.

The Website URL column in `arctl skill list` is almost always empty,
adding clutter without useful information. Remove it from the list
table while keeping it in the detailed `skill show` output.

Fixes agentregistry-dev#256

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@peterj
Copy link
Copy Markdown
Contributor

peterj commented Mar 5, 2026

we can also remove the Category column.

And we should add a "Type" and "Source" column (i am open to different names if it makes sense). We'd display whether the skill is registered from a docker image or if it's registeted with a github repo :

// if set, has the git info
s.Skill.Repository...
// if there are packages (typically there would be one, but could be more), we display the type and the identifier 
s.Skill.Packages[0].RegistryType

Also, please make sure to fill out the PR template correctly

Remove the empty Category and Website columns. Add Type (registryType or
repository source) and Source (package identifier or repository URL) columns
to show where each skill comes from.

Addresses review feedback on agentregistry-dev#269.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@optimus-fulcria
Copy link
Copy Markdown
Contributor Author

@peterj Updated — removed the Category column and added Type + Source columns.

  • Type: Packages[0].RegistryType (docker/oci/npm) or Repository.Source (github)
  • Source: Packages[0].Identifier or Repository.URL
  • Falls back to <none> when neither packages nor repository info is set.

Also updated the PR description to follow the template.

}
}

func skillSource(s *models.SkillResponse) (string, string) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a quick unit test for this too please. thanks!

Table-driven test covering package source, repository source,
package-over-repository precedence, and the no-source fallback.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@optimus-fulcria
Copy link
Copy Markdown
Contributor Author

Added unit test for skillSource — table-driven with four cases: package source, repository source, package precedence over repository, and no-source fallback. All passing.

@optimus-fulcria
Copy link
Copy Markdown
Contributor Author

Updated per your feedback:

  • Category column removed
  • Type column added (shows RegistryType from packages or source from repository)
  • Source column added (shows package identifier or repository URL)
  • PR description filled out per template
  • Unit test added for the skillSource helper

The columns now show actionable info about where each skill is registered from.

@peterj peterj added this pull request to the merge queue Mar 6, 2026
Merged via the queue into agentregistry-dev:main with commit 8f72a61 Mar 6, 2026
7 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Mar 9, 2026
# Description

Completes the cleanup started in #269 by applying the same improvements
to the `skill show` command.

**Changes:**
- Remove empty/nonsensical **Category** and **Website** columns from
`skill show` output
- Replace with useful **Type** and **Source** fields (reusing
`skillSource()` from the list command)
- Add **Title** field for consistency with `skill list`
- Fix potential nil pointer dereference when `Meta.Official` is nil

Fixes #256

/kind cleanup

# Changelog

```release-note
Clean up skill show command to remove empty Category/Website fields and show Type/Source instead
```

# Additional Notes

PR #269 cleaned up the `skill list` command. This PR applies the same
treatment to `skill show`, fully resolving issue #256.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 <[email protected]>
christian-posta pushed a commit to christian-posta/agentregistry that referenced this pull request Mar 9, 2026
…y-dev#269)

# Description

Remove uninformative columns from `arctl skill list` output and add
useful ones.

**Motivation:** The Website column was always empty and the Category
column provided little value. Type and Source give users actionable
information about where a skill comes from.

**What changed:**
- Removed empty Website column
- Removed Category column (per review feedback)
- Added Type column showing `registryType` (docker/oci/npm) or
repository source (github)
- Added Source column showing package identifier or repository URL

# Change Type

/kind fix

# Changelog

```release-note
Show Type and Source columns instead of Category and Website in skill list output
```

# Additional Notes

Uses `Packages[0].RegistryType` / `Packages[0].Identifier` for
package-based skills and `Repository.Source` / `Repository.URL` for
GitHub-published skills, falling back to `<none>` when neither is set.

Unit test added for the `skillSource` helper with four cases: package
source, repository source, package precedence, and no-source fallback.

---------

Co-authored-by: Claude Opus 4.6 <[email protected]>
christian-posta pushed a commit to christian-posta/agentregistry that referenced this pull request Mar 9, 2026
# Description

Completes the cleanup started in agentregistry-dev#269 by applying the same improvements
to the `skill show` command.

**Changes:**
- Remove empty/nonsensical **Category** and **Website** columns from
`skill show` output
- Replace with useful **Type** and **Source** fields (reusing
`skillSource()` from the list command)
- Add **Title** field for consistency with `skill list`
- Fix potential nil pointer dereference when `Meta.Official` is nil

Fixes agentregistry-dev#256

/kind cleanup

# Changelog

```release-note
Clean up skill show command to remove empty Category/Website fields and show Type/Source instead
```

# Additional Notes

PR agentregistry-dev#269 cleaned up the `skill list` command. This PR applies the same
treatment to `skill show`, fully resolving issue agentregistry-dev#256.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants