fix: clarify --registry-url and --project-dir flag descriptions#268
Merged
peterj merged 3 commits intoagentregistry-dev:mainfrom Mar 6, 2026
Merged
Conversation
Standardize flag descriptions across all commands: - Remove redundant "(default: current directory)" from --project-dir since cobra already shows the default value - Use consistent "defaults to the currently configured registry" phrasing for --registry-url across add-prompt, add-skill, and add-mcp - Use consistent "defaults to latest" for version flags - Remove unnecessary "(optional)" annotations Fixes agentregistry-dev#244 Co-Authored-By: Claude Opus 4.6 <[email protected]>
peterj
reviewed
Mar 5, 2026
internal/cli/agent/add-mcp.go
Outdated
| AddMcpCmd.Flags().StringVar(®istryURL, "registry-url", "", "Registry URL (defaults to the currently configured registry; mutually exclusive with --remote, --command, --image, --build)") | ||
| AddMcpCmd.Flags().StringVar(®istryServerName, "registry-server-name", "", "MCP server name in the registry (mutually exclusive with --remote, --command, --image, --build)") | ||
| AddMcpCmd.Flags().StringVar(®istryServerVersion, "registry-server-version", "", "MCP server version to pull from the registry (defaults to latest)") | ||
| AddMcpCmd.Flags().BoolVar(®istryServerPreferRemote, "registry-server-prefer-remote", false, "Prefer remote MCP server over local deployment") |
Contributor
There was a problem hiding this comment.
this is not true -- the preferRemote is something we need to actually remove; but the idea here was that if an MCP server has multiple packages, this flag would prefer the remote package.
peterj
reviewed
Mar 5, 2026
internal/cli/agent/add-prompt.go
Outdated
| AddPromptCmd.Flags().StringVar(&promptRegistryURL, "registry-url", "", "Registry URL (defaults to the currently configured registry)") | ||
| AddPromptCmd.Flags().StringVar(&promptRegistryPromptName, "registry-prompt-name", "", "Prompt name in the registry") | ||
| AddPromptCmd.Flags().StringVar(&promptRegistryPromptVersion, "registry-prompt-version", "", "Version of the prompt to pull from the registry") | ||
| AddPromptCmd.Flags().StringVar(&promptRegistryPromptVersion, "registry-prompt-version", "", "Prompt version to pull from the registry (defaults to latest)") |
Contributor
There was a problem hiding this comment.
while you're here -- can you set the default value here to "latest" then
peterj
reviewed
Mar 5, 2026
| AddMcpCmd.Flags().StringVar(&image, "image", "", "Container image (mutually exclusive with --build)") | ||
| AddMcpCmd.Flags().StringVar(&build, "build", "", "Container build (mutually exclusive with --image)") | ||
| AddMcpCmd.Flags().StringVar(®istryURL, "registry-url", "", "Registry URL (defaults to the currently configured registry; mutually exclusive with --remote, --command, --image, --build)") | ||
| AddMcpCmd.Flags().StringVar(®istryServerName, "registry-server-name", "", "MCP server name in the registry (mutually exclusive with --remote, --command, --image, --build)") |
Contributor
There was a problem hiding this comment.
could you keep the changes to the --registry-url and --project-dir?
- Revert preferRemote description to original (not about local vs remote) - Set --registry-prompt-version default value to "latest" - Keep --registry-url and --project-dir description improvements Co-Authored-By: Claude Opus 4.6 <[email protected]>
…eferRemote description - Set --registry-server-version default to "latest" (matching add-prompt behavior) - Fix --registry-server-prefer-remote description to explain actual behavior: when an MCP server has multiple packages, prefer the remote package Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
@peterj Addressed your feedback:
|
Contributor
Author
|
All three review points have been addressed in the latest push:
|
peterj
approved these changes
Mar 6, 2026
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
…tregistry-dev#268) # Description Clarify the `--registry-url` and `--project-dir` flag descriptions to help users understand what they do. **What changed:** - `--registry-url`: Updated description to explain it sets the registry server URL - `--project-dir`: Updated description to explain it sets the working directory for project files Fixes agentregistry-dev#261 # Change Type /kind fix # Changelog ```release-note Clarify --registry-url and --project-dir flag descriptions ``` --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify the
--registry-urland--project-dirflag descriptions to help users understand what they do.What changed:
--registry-url: Updated description to explain it sets the registry server URL--project-dir: Updated description to explain it sets the working directory for project filesFixes #261
Change Type
/kind fix
Changelog