add UI for prompts, tests and storybook setup#261
Conversation
Signed-off-by: Peter Jausovec <[email protected]>
Signed-off-by: Peter Jausovec <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds UI support for managing prompts in the registry, including list/detail views, a create dialog, and establishes the testing and Storybook infrastructure for UI components.
Changes:
- Adds
PromptCard,PromptDetail, andAddPromptDialogcomponents for prompt management UI, and integrates them into the main admin page - Sets up Vitest for UI unit testing with tests for
Button,Badge,PromptCard,AgentCard,ServerCard, andSkillCard - Sets up Storybook for UI component development with stories for all card components
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
ui/app/page.tsx |
Integrates prompt listing, filtering, pagination, detail view, and add-dialog |
ui/components/prompt-card.tsx |
New card component for displaying a prompt in the list |
ui/components/prompt-detail.tsx |
New full-page detail view for a prompt |
ui/components/add-prompt-dialog.tsx |
New dialog for creating a prompt |
ui/components/prompt-card.stories.tsx |
Storybook stories for PromptCard |
ui/components/server-card.stories.tsx |
Storybook stories for ServerCard (inconsistent import) |
ui/components/skill-card.stories.tsx |
Storybook stories for SkillCard (inconsistent import) |
ui/components/agent-card.stories.tsx |
Storybook stories for AgentCard |
ui/components/__tests__/prompt-card.test.tsx |
Unit tests for PromptCard |
ui/components/__tests__/server-card.test.tsx |
Unit tests for ServerCard |
ui/components/__tests__/skill-card.test.tsx |
Unit tests for SkillCard |
ui/components/__tests__/agent-card.test.tsx |
Unit tests for AgentCard |
ui/components/ui/__tests__/button.test.tsx |
Unit tests for Button |
ui/components/ui/__tests__/badge.test.tsx |
Unit tests for Badge |
ui/vitest.config.ts |
Vitest configuration |
ui/vitest.setup.ts |
Vitest setup file |
ui/package.json |
Adds test/Storybook scripts and dependencies |
ui/eslint.config.mjs |
Adds Storybook ESLint plugin (unused import) |
ui/.storybook/main.ts |
Storybook main config |
ui/.storybook/preview.ts |
Storybook preview config |
ui/.gitignore |
Adds Storybook build artifacts to gitignore |
.github/workflows/build.yml |
Adds UI test step to CI (missing npm install) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Peter Jausovec <[email protected]>
|
addresses #252 |
inFocus7
left a comment
There was a problem hiding this comment.
non-blocking nit: could we also add the @storybook/addon-a11y addon for accessibility insights in storybook? https://storybook.js.org/addons/@storybook/addon-a11y
should be something like running npm install @storybook/[email protected] --save-dev in /ui and adding it to the list of storybook addons in the storybook config
Signed-off-by: Peter Jausovec <[email protected]>
# Description Clarify the `--registry-url` and `--project-dir` flag descriptions to help users understand what they do. **What changed:** - `--registry-url`: Updated description to explain it sets the registry server URL - `--project-dir`: Updated description to explain it sets the working directory for project files Fixes #261 # Change Type /kind fix # Changelog ```release-note Clarify --registry-url and --project-dir flag descriptions ``` --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
<!-- Thanks for opening a PR! Please delete any sections that don't apply. --> Adds UI for managing prompts. Adds ui tests and sets up storybook for ui components. ``` /kind feature ``` ```release-note add UI for prompts ``` --------- Signed-off-by: Peter Jausovec <[email protected]>
…tregistry-dev#268) # Description Clarify the `--registry-url` and `--project-dir` flag descriptions to help users understand what they do. **What changed:** - `--registry-url`: Updated description to explain it sets the registry server URL - `--project-dir`: Updated description to explain it sets the working directory for project files Fixes agentregistry-dev#261 # Change Type /kind fix # Changelog ```release-note Clarify --registry-url and --project-dir flag descriptions ``` --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
Description
Adds UI for managing prompts. Adds ui tests and sets up storybook for ui components.
Change Type
Changelog
Additional Notes