internal: Materialize skills during agent run#215
Merged
timflannagan merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
timflannagan
commented
Feb 25, 2026
internal/cli/agent/run.go
Outdated
Comment on lines
+73
to
+76
| // Note: The below implementation may be redundant in most cases. | ||
| // It allows for registry-type MCP server resolution at run-time, but in doing so, it regenerates folders for servers which were already accounted for (i.e. command-type get generated during their `add-cmd` command) | ||
| // It allows for registry-type MCP server resolution at run-time, but in doing so, it | ||
| // regenerates folders for servers which were already accounted for (i.e. command-type get | ||
| // generated during their `add-cmd` command). |
Collaborator
Author
There was a problem hiding this comment.
TODO: I think this comment is potentially stale?
timflannagan
commented
Feb 25, 2026
timflannagan
commented
Feb 25, 2026
timflannagan
commented
Feb 25, 2026
timflannagan
commented
Feb 25, 2026
timflannagan
commented
Feb 25, 2026
timflannagan
commented
Feb 25, 2026
peterj
reviewed
Feb 25, 2026
peterj
reviewed
Feb 25, 2026
peterj
reviewed
Feb 25, 2026
peterj
reviewed
Feb 25, 2026
peterj
reviewed
Feb 25, 2026
This adds runtime skill resolution and extraction for agent runs, including registry-backed skill references, so local and registry runs can mount usable skill content consistently. Previously, agent run only handled MCP runtime artifacts. Now we resolve skill image references, enforce strict image-versus-registry input validation at runtime, materialize skill files into the runtime config path, and cover the behavior with focused tests. Follow-up to #198.
Signed-off-by: timflannagan <[email protected]>
e29877c to
99ba4c4
Compare
peterj
approved these changes
Feb 26, 2026
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
# Description Follow-up to agentregistry-dev#198 that added support for adding metadata to the agent.yaml. This commit adds runtime skill resolution and materialization for `agent run` workflows. When skills have been configured for an agent, we resolve those [ image, registryURL ] input sources to images, and then leverage docker create/cp/etc. to fetch those contents and extract directly to disk. We leverage existing kagent-adk functionality here where it supports reading skills from an envvar so I only had to extend the docker compose template to mount that directory correctly. # Change Type /kind feature # Changelog ```release-note NONE ``` --------- Signed-off-by: timflannagan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #198 that added support for adding metadata to the agent.yaml. This commit adds runtime skill resolution and materialization for
agent runworkflows. When skills have been configured for an agent, we resolve those [ image, registryURL ] input sources to images, and then leverage docker create/cp/etc. to fetch those contents and extract directly to disk.We leverage existing kagent-adk functionality here where it supports reading skills from an envvar so I only had to extend the docker compose template to mount that directory correctly.
Change Type
/kind feature
Changelog