fix(cli): Fix Docker image tag duplication in skill publish#202
Merged
timflannagan merged 1 commit intoagentregistry-dev:mainfrom Feb 24, 2026
Merged
Conversation
BuildRegistryImageName was called with an already-tagged image name from BuildLocalImageName, producing invalid references like "registry/my-project:latest:latest". Pass the raw name instead. Fixes agentregistry-dev#178
This was referenced Feb 21, 2026
Collaborator
|
(Ci was stuck with the updated GHA workflows). |
timflannagan
approved these changes
Feb 24, 2026
Collaborator
timflannagan
left a comment
timflannagan
left a comment
There was a problem hiding this comment.
Ran into this locally as well. LGTM. cc @peterj
peterj
approved these changes
Feb 24, 2026
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
…istry-dev#202) # Description `arctl skill publish` produces invalid Docker image references with duplicated tags (e.g., `docker.io/user/my-project:latest:latest`). **Root cause:** In `buildSkillDockerImage`, `BuildRegistryImageName` was called with the output of `BuildLocalImageName` (which already includes a version tag) instead of the raw name. Since `BuildRegistryImageName` internally calls `BuildLocalImageName`, the tag was applied twice. **Fix:** Pass `fm.Name` directly to `BuildRegistryImageName`, matching the existing pattern in `GetImageNameFromManifest` (common.go:58). Fixes agentregistry-dev#178 # Change Type /kind fix # Changelog ```release-note Fix Docker image tag duplication (`:latest:latest`) in `arctl skill publish` ``` # Additional Notes - Added 2 test cases to `TestBuildRegistryImageName` covering registry URLs with path components - Added `TestBuildRegistryImageName_NoDoubleTag` regression test asserting no double-tag patterns - Removed unused `repoName` variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
arctl skill publishproduces invalid Docker image references with duplicatedtags (e.g.,
docker.io/user/my-project:latest:latest).Root cause: In
buildSkillDockerImage,BuildRegistryImageNamewas calledwith the output of
BuildLocalImageName(which already includes a version tag)instead of the raw name. Since
BuildRegistryImageNameinternally callsBuildLocalImageName, the tag was applied twice.Fix: Pass
fm.Namedirectly toBuildRegistryImageName, matching theexisting pattern in
GetImageNameFromManifest(common.go:58).Fixes #178
Change Type
/kind fix
Changelog
Additional Notes
TestBuildRegistryImageNamecovering registry URLs with path componentsTestBuildRegistryImageName_NoDoubleTagregression test asserting no double-tag patternsrepoNamevariable